chore: error msgs #494
Merged
chore: error msgs #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbajolet-hashicorp
force-pushed
the
chore/error-msgs
branch
from
2d6d3a7 to
e84bd29
Compare
Contributor
lbajolet-hashicorp
left a comment
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Left a few nits on some comments, mostly to steer users towards a resolution in some cases, but besides that this LGTM!
tenthirtyam
force-pushed
the
chore/error-msgs
branch
from
e84bd29 to
539f4a3
Compare
Error messages should not begin with capitalization or end with punctuation. Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
chore/error-msgs
branch
from
539f4a3 to
b78f413
Compare
Collaborator
Author
|
@lbajolet-hashicorp - ready for review again. |
lbajolet-hashicorp
approved these changes
Jan 27, 2025
Contributor
lbajolet-hashicorp
left a comment
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
LGTM, thanks for the reroll @tenthirtyam!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages should not begin with capitalization or end with punctuation.