feat: upload max retries #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nywilken
reviewed
Mar 19, 2024
Contributor
nywilken
left a comment
nywilken
left a comment
There was a problem hiding this comment.
Overall this looks good. I left a question and one possible suggestion. Please let me know what you think.
tenthirtyam
force-pushed
the
feat-upload-max-retries
branch
3 times, most recently
from
2f690d0 to
1c1e3dd
Compare
- Updates the `vsphere` post-processor to support `max_retries` for the upload to a vSphere endpoint. Defaults to 5. - Sets and uses constants for `DefaultMaxRetries`, `DefaultDiskMode`, and `OvftoolWindows`. Ref: #30 Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
feat-upload-max-retries
branch
from
1c1e3dd to
d3ea40c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vspherepost-processor to supportmax_retriesfor the upload to a vSphere endpoint. Defaults to 5.DefaultMaxRetries,DefaultDiskMode, andOvftoolWindows.Reference
Closes #30