Skip to content

docs: update vsphere/clone/step_clone #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nywilken merged 1 commit into from
Mar 5, 2024
Merged

docs: update vsphere/clone/step_clone #374

nywilken merged 1 commit into from
Mar 5, 2024

Conversation

@tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Mar 5, 2024

Summary

Updates descriptions for generated documentation.

Testing

packer-plugin-vsphere on  docs/update-step-clone via 🐹 v1.22.0 
➜ make build   


packer-plugin-vsphere on  docs/update-step-clone via 🐹 v1.22.0 took 4.2s 
➜ make generate
2024/03/04 22:16:49 Copying "docs" to ".docs/"
2024/03/04 22:16:49 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...


packer-plugin-vsphere on  docs/update-step-clone via 🐹 v1.22.0 took 11.5s 
➜ make test    
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.001s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.316s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       4.645s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  2.307s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   4.614s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.992s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.859s

@tenthirtyam
docs: update vsphere/clone/step_clone
ec42fa0 
Updates descriptions for generated documentation.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the documentation Improvements or additions to documentation label Mar 5, 2024
@tenthirtyam tenthirtyam self-assigned this Mar 5, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner March 5, 2024 03:17
nywilken
nywilken approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates. LGTM

@nywilken nywilken merged commit 8bde03d into main Mar 5, 2024
@nywilken nywilken deleted the docs/update-step-clone branch March 5, 2024 23:34
@tenthirtyam tenthirtyam added this to the v1.2.5 milestone Mar 6, 2024
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lbajolet-hashicorp lbajolet-hashicorp Awaiting requested review from lbajolet-hashicorp

1 more reviewer

@nywilken nywilken nywilken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

v1.2.6

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @nywilken