Skip to content

chore: correct typos and markdown #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nywilken merged 1 commit into from
Mar 5, 2024
Merged

chore: correct typos and markdown #370

nywilken merged 1 commit into from
Mar 5, 2024

Conversation

@tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Mar 2, 2024

Summary

Technical Debt:

  • Correct misspellings and grammar.
  • Correct version of Go in README.md to match go.mod.
  • Correct markdownlint issues in CHANGELOG.md.

Testing

> make generate
2024/03/01 22:55:03 Copying "docs" to ".docs/"
2024/03/01 22:55:03 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

> make build   

> make test 
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.744s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.671s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.534s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  1.387s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   4.190s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.295s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      1.615s
``

@tenthirtyam tenthirtyam added the chore Chore label Mar 2, 2024
@tenthirtyam tenthirtyam self-assigned this Mar 2, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner March 2, 2024 03:58
@tenthirtyam
chore: correct typos and markdown
0a72e8c 
Technical Debt:

- Correct misspellings and grammar.
- Correct version of Go in `README.md` to match `go.mod`.
- Correct markdownlint issues in `CHANGELOG.md`.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the chore/typos-markdown branch from 1aa414c to 0a72e8c Compare March 4, 2024 03:40
nywilken
nywilken approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - Thank you!

@nywilken nywilken merged commit acb47ad into main Mar 5, 2024
@nywilken nywilken deleted the chore/typos-markdown branch March 5, 2024 01:08
@nywilken nywilken added the documentation Improvements or additions to documentation label Mar 5, 2024
@tenthirtyam tenthirtyam added this to the v1.2.5 milestone Mar 6, 2024
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lbajolet-hashicorp lbajolet-hashicorp Awaiting requested review from lbajolet-hashicorp

1 more reviewer

@nywilken nywilken nywilken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

chore Chore documentation Improvements or additions to documentation

Projects

None yet

Milestone

v1.2.6

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @nywilken