chore(tests): remove unnecessary AddCdromCalled
#352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
changed the title
AddCdromCalled
Collaborator
|
✅ CI Passed. Run echo "Testing with Go 1.20.10"
Testing with Go 1.20.10
? github.com/hashicorp/packer-plugin-vsphere [no test files]
ok github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone 0.112s
? github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing [no test files]
? github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver [no test files]
ok github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common 1.073s
? github.com/hashicorp/packer-plugin-vsphere/version [no test files]
ok github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver 4.[6](https://github.com/hashicorp/packer-plugin-vsphere/actions/runs/7330363187/job/19965407964?pr=352#step:4:7)92s
ok github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso 0.092s
ok github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor 2.193s
ok github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere 0.062s
ok github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template 0.09[7](https://github.com/hashicorp/packer-plugin-vsphere/actions/runs/7330363187/job/19965407964?pr=352#step:4:8)s |
tenthirtyam
approved these changes
Jan 8, 2024
Collaborator
tenthirtyam
left a comment
tenthirtyam
left a comment
There was a problem hiding this comment.
LGTM. But I suggest merging this after the changes for reattaching the CD-ROM and another CI pass,
nywilken
approved these changes
Jan 9, 2024
Contributor
nywilken
left a comment
nywilken
left a comment
There was a problem hiding this comment.
Thanks for this change. I agree it is not needed given the existence of AddCdromCalledTimes
There is an AddCdromCalledTimes which serves the same purpose
nywilken
force-pushed
the
simplify-tests
branch
from
c4a18bc to
8082cd5
Compare
Contributor
|
@Hi-Angel I rebased and pushed the latest changes from main to fix the reattach CDROMs tests. I will merged once all goes green. |
Contributor
Author
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an AddCdromCalledTimes which serves the same purpose