Skip to content

docs: update disk_size from mb to mib #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbajolet-hashicorp merged 1 commit into from
Jan 8, 2024
Merged

docs: update disk_size from mb to mib #349

lbajolet-hashicorp merged 1 commit into from
Jan 8, 2024

Conversation

@tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Dec 19, 2023 •
edited
Loading

  • Updates disk_size from MB to MiB.
  • Minor text updates.

Closes #348

packer-plugin-vsphere on docs/mb-to-mib
➜ go fmt ./...         

packer-plugin-vsphere on docs/mb-to-mib
➜ make build

packer-plugin-vsphere on docs/mb-to-mib
➜ export PATH=$PATH:$(go env GOPATH)/bin

packer-plugin-vsphere on docs/mb-to-mib
➜ make generate
2023/12/19 15:34:42 Copying "docs" to ".docs/"
2023/12/19 15:34:42 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vsphere on docs/mb-to-mib took 34.4s 
➜ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.846s
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.342s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.729s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  2.702s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   5.014s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.506s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.030s

@tenthirtyam tenthirtyam added the documentation Improvements or additions to documentation label Dec 19, 2023
@tenthirtyam tenthirtyam self-assigned this Dec 19, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner December 19, 2023 20:41
@tenthirtyam tenthirtyam mentioned this pull request Dec 19, 2023
Closed
@tenthirtyam
docs: update disk_size from mb to mib
302e2e0 
Updates `disk_size` from MB to MiB.

Ref: #348

Signed-off-by: Ryan Johnson <[email protected]>
@lindhe
Copy link

lindhe commented Dec 20, 2023

I think the changes looks good. My only comments are on the PR title:

  1. It should probably say "from MB to MiB" instead of "from mb to mib", just for consistency.
  2. There are some other changes that are not reflected by the PR title. I don't think it's necessary break this up into into multiple PRs, so perhaps a simple addition of "and other changes" is good enough.

Please at least consider the first point. Apart from that, LGTM and I think it can be merged. Great job! 💪

@tenthirtyam
Copy link
Collaborator Author

tenthirtyam commented Dec 20, 2023

I always use lowercase conventional commits unless it specifies a file name. :)

lbajolet-hashicorp
lbajolet-hashicorp approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 6885660 into main Jan 8, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the docs/mb-to-mib branch January 8, 2024 20:50
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missleading documentation: disk_size is in MiB not in MB

3 participants

@tenthirtyam @lindhe @lbajolet-hashicorp