Skip to content

Conversation

@sudomateo
Copy link
Contributor

@sudomateo sudomateo commented Apr 14, 2025

Updated the doc.go file to adhere to Go Doc Comment syntax. This allows the documentation to render correctly on pkg.go.dev.

I was reading the multistep package documentation when I noticed this. Perhaps there are more packages that need updating but I didn't enumerate them.

Before

Screenshot From 2025-04-14 15-50-19

After

Screenshot From 2025-04-14 15-50-24

Updated the `doc.go` file to adhere to
[Go Doc Comment](https://go.dev/doc/comment) syntax. This allows
the documentation to render correctly on `pkg.go.dev`.

I was reading the `multistep` package documentation when I noticed
this. Perhaps there are more packages that need updating but I didn't
enumerate them.
@sudomateo sudomateo requested a review from a team as a code owner April 14, 2025 19:55
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sudomateo, good to see you here :)

Thanks for the PR, the change looks good to me! You're right that some other packages might need changes similar to this one, we should probably take a look at this, thanks!

@sudomateo
Copy link
Contributor Author

Hey @sudomateo, good to see you here :)

Thanks for the PR, the change looks good to me! You're right that some other packages might need changes similar to this one, we should probably take a look at this, thanks!

Nice to see you as well. Hope all is well with you!

As I build out our Oxide Packer plugin I'll submit pull requests if I see any other areas that need updating. Thank you for the review!

@lbajolet-hashicorp
Copy link
Contributor

Oh, interesting that Oxide's building a Packer plugin for their platform, colour me intrigued :)

Good luck on that endeavour, hope it turns out well! When you have releases ready feel free to onboard the docs on devdot, this will make it more visible!

Merging this one now

@lbajolet-hashicorp lbajolet-hashicorp merged commit 8a318d2 into hashicorp:main Apr 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants