commonsteps: StepDownload timeout override #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogrogan
force-pushed
the
stepdownload_timeout_override
branch
4 times, most recently
from
df4c3ee to
a695a51
Compare
lbajolet-hashicorp
previously approved these changes
Jan 20, 2025
Contributor
lbajolet-hashicorp
left a comment
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Hey @mogrogan,
Overall LGTM, thanks. I left a few comments on the code, which are more nitpicks/docs changes than anything else. Feel free to let me know how you want to proceed with those, and we might be able to merge this today.
|
|
||
| func prepareGetterClient() { | ||
| getterReadTimeout := defaultGetterReadTimeout | ||
| if env, exists := os.LookupEnv("PACKER_GETTER_READ_TIMEOUT"); exists { |
Contributor
There was a problem hiding this comment.
Note to myself: we'll need to add that new envvar to the docs somewhere
Should now be overridable via the environment variable PACKER_GETTER_READ_TIMEOUT
mogrogan
force-pushed
the
stepdownload_timeout_override
branch
from
a695a51 to
bf93226
Compare
lbajolet-hashicorp
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should now be overridable via the environment variable
PACKER_GETTER_READ_TIMEOUT