Skip to content

Fixed wrong parameter in doc #12949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbajolet-hashicorp merged 1 commit into from
Jun 3, 2024
Merged

Fixed wrong parameter in doc #12949

lbajolet-hashicorp merged 1 commit into from
Jun 3, 2024

Conversation

@mr-aboutin
Copy link
Contributor

@mr-aboutin mr-aboutin commented Apr 30, 2024

Replace ssh_file_transfer_protocol with ssh_file_transfer_method in documentation since the former does not exist as a parameter.

@mr-aboutin mr-aboutin requested a review from a team as a code owner April 30, 2024 14:53
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Apr 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

lbajolet-hashicorp
lbajolet-hashicorp approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @mr-aboutin, thanks for the fix.

Merging now

@lbajolet-hashicorp lbajolet-hashicorp merged commit 3fb6b76 into hashicorp:main Jun 3, 2024
@lbajolet-hashicorp
Copy link
Contributor

lbajolet-hashicorp commented Jun 3, 2024

Wait I just realised this is from the generated partials, this will be reverted when the docs are re-updated...
This should be an SDK fix to the docs that this is extracted from (that will make it possible for every plugin that includes this partial in their docs to have it updated). I assume this is included in Packer core but not used/referenced in the docs, hence why this didn't fail for make generate.

Sorry about this blunder.

@lbajolet-hashicorp lbajolet-hashicorp mentioned this pull request Jun 3, 2024
Merged
@github-actions
Copy link

github-actions bot commented Jul 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mr-aboutin @lbajolet-hashicorp