product: Use version json output (consul + terraform)#276
Merged
radeksimko merged 2 commits intomainfrom Jan 9, 2025
Merged
Conversation
SarahFrench
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Other products do not seem to have
versionJSON output.Existing tests will exercise the new codepath, although admittedly the legacy part will not be exercised. The difficulty with testing it is that older versions of Terraform and Consul aren't available on some OS/platform combinations like darwin/arm64.
I think the lack of testing is ok for now, in part because we'll gain some more debugging capabilities as part of #46 hopefully.