releasesjson: Always remove unpacked archive#273
Merged
radeksimko merged 1 commit intomainfrom Jan 6, 2025
Merged
Conversation
radeksimko
force-pushed
the
f-always-remove-archive
branch
from
5fb4526 to
4ab591b
Compare
As mentioned in #145 we never reuse the archive and so it makes sense to *always* remove it rather then collect it for removal by end-user via Remove() method.
radeksimko
force-pushed
the
f-always-remove-archive
branch
from
4ab591b to
c2b123b
Compare
dbanck
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #145 we never reuse the archive and so it makes sense to always remove it rather then collect it for removal by end-user via
Remove()method.This in turn reduces disk space in situations where it is important (outside of disposable CI environments).
Closes #145