httpclient: Reuse existing configured logger#240
Conversation
|
Can we add a regression test for the #239 behaviour? |
kmoe
left a comment
There was a problem hiding this comment.
Happy to merge with tests added or those can come in a later PR so as not to block release.
|
If we could hold off on doing a release until hashicorp/hc-passport-groups#1674 (hopefully) gets merged and I set up the same for |
|
I'm not sure how to test this with the current setup in the context of a library. We could be testing any STDOUT/STDERR output but that falls mostly under #65 so I'll merge this PR without a test and we can follow up there. - that is once https://github.com/hashicorp/hc-passport-groups/pull/1674 is merged. |
Fixes #239