[fix] include custom url's "path" when creating Archive URL#234
Merged
radeksimko merged 4 commits intohashicorp:mainfrom Aug 1, 2024
james0209:fix-custom-archive-url
Merged
[fix] include custom url's "path" when creating Archive URL#234radeksimko merged 4 commits intohashicorp:mainfrom james0209:fix-custom-archive-url
radeksimko merged 4 commits intohashicorp:mainfrom
james0209:fix-custom-archive-url
Conversation
Contributor
Author
|
Hey @radeksimko, could we get a review/approval here please? 🙏 |
james0209
changed the title
radeksimko
approved these changes
Aug 1, 2024
Member
radeksimko
left a comment
radeksimko
left a comment
There was a problem hiding this comment.
That is reasonable patch, thanks for sending it in.
We naturally didn't run into this problem under tests as tests use the same path - just different scheme and host.
Member
|
This was just released under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Currently when constructing the archive URL for download, only
SchemeandHostare considered. This meams anyPathwithin the custom URL is not used when constructing the Archive URL.References
closes runatlantis/atlantis#4778