Merged
Conversation
Contributor
|
Hey @radeksimko, is there a reason that the Line 3 in 2597d9e |
Member
Author
|
@james0209 As far as I'm aware, the version there just communicates compatibility and we had no reason to require higher versions and impose that to downstream, so it's mostly just path of least resistance. 🤷🏻♂️ |
kmoe
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to suppress vulnerability scanner noise caused by https://nvd.nist.gov/vuln/detail/CVE-2024-24789
I believe that
hc-installis not impacted by it as we generally unpack ZIP files we produce ourselves, rather than arbitrary ones.We should still call it out in the Changelog though.