[feat] Allow "LicenseDir" field for non-enterprise usage#214
Merged
radeksimko merged 21 commits intohashicorp:mainfrom May 29, 2024
james0209:add-license-dir-non-enterprise
Merged
[feat] Allow "LicenseDir" field for non-enterprise usage#214radeksimko merged 21 commits intohashicorp:mainfrom james0209:add-license-dir-non-enterprise
radeksimko merged 21 commits intohashicorp:mainfrom
james0209:add-license-dir-non-enterprise
Conversation
… path copies the file as "LICENSE.txt" regardless of if the src file is "LICENSE" or "LICENSE.txt"
james0209
changed the title
radeksimko
reviewed
May 28, 2024
Member
radeksimko
left a comment
radeksimko
left a comment
There was a problem hiding this comment.
This is looking pretty good aside from my inline comments!
Also thanks for handling the situation with enterprise versions. I did not realise we would have when writing the linked issue.
This does imply breaking change but it seems worth making, we just need to call it out in the Changelog (which I can do once it's merged).
2. Remove test
Co-authored-by: Radek Simko <[email protected]>
radeksimko
approved these changes
May 29, 2024
Member
radeksimko
left a comment
radeksimko
left a comment
There was a problem hiding this comment.
Mostly minor concerns remaining as per my comments inline. Once those are addressed I'm more than happy to merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
High-level overview
Introduces
LicenseDirfield into the following:build.GitRevisioncheckpoint.LatestVersionreleases.ExactVersionreleases.LatestVersionversions.InstallationOptionsRemoves
LicenseDirfield from:EnterpriseOptionsbuild.GitRevision
pathsToRemoveto match other uses.checkpoint.LatestVersion
DownloadAndUnpackcallcheckpointdoesn't support Enterprise, and before this PR, it was assumed that only Enterprise versions would contain a License.versions.InstallationOptions
InstallationOptions- same struct that containsInstallDir.Why
Closes #213