Skip to content

releasesjson: Fix missing Version in unmarshaled response#192

Merged
radeksimko merged 1 commit intomainfrom
b-fix-unmarshalling-error
Apr 4, 2024
Merged

releasesjson: Fix missing Version in unmarshaled response#192
radeksimko merged 1 commit intomainfrom
b-fix-unmarshalling-error

Conversation

@radeksimko
Copy link
Copy Markdown
Member

@radeksimko radeksimko commented Apr 4, 2024 •
edited
Loading

I cannot think of a good reason why we had the RawVersion field there. It may have pre-dated go-version's ability to unmarshal. Either way, this has led to a weird error message, as discovered by @bschaatsbergen in #191

 $ ./hc-install install -version 1.0.0 terraform
hc-install: will install [email protected]
failed to install [email protected]: no ZIP archive found for terraform <nil> darwin/arm64

After patch

$ go run ./cmd/hc-install install -version 1.0.0 terraform
hc-install: will install [email protected]
failed to install [email protected]: no ZIP archive found for terraform 1.0.0 darwin/arm64
exit status 1

@bschaatsbergen bschaatsbergen mentioned this pull request Apr 4, 2024
Closed
@radeksimko radeksimko marked this pull request as ready for review April 4, 2024 09:56
bschaatsbergen
bschaatsbergen approved these changes Apr 4, 2024
View reviewed changes
Copy link
Copy Markdown

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@radeksimko radeksimko added the bug Something isn't working label Apr 4, 2024
@radeksimko radeksimko merged commit 6d13f0e into main Apr 4, 2024
@radeksimko radeksimko deleted the b-fix-unmarshalling-error branch April 4, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bschaatsbergen bschaatsbergen bschaatsbergen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radeksimko @bschaatsbergen