chore: improve error message, since version is nil#191
Closed
bschaatsbergen wants to merge 2 commits intohashicorp:mainfrom
Closed
chore: improve error message, since version is nil#191bschaatsbergen wants to merge 2 commits intohashicorp:mainfrom
bschaatsbergen wants to merge 2 commits intohashicorp:mainfrom
Conversation
Author
|
Closing this in favor of #192 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
hc-installlooks for a release that we don't have binaries for (e.g. terraform 1.0.0 darwin/arm64), we print an error message containing a nil:At first, I assumed there might be a bug in
hc-installbecause of seeing that nil. After checking the Release index I noticed we started building darwin/arm64 binaries starting from 1.1.I'm assuming that the nil is the result of marshaling the Release API response, which can't list the product and doesn't return a version?
This PR changes the error message to: