deps: Bump ProtonMail/go-crypto to v1.1.0-alpha.0#183
Merged
radeksimko merged 1 commit intomainfrom Feb 6, 2024
Merged
Conversation
dbanck
approved these changes
Feb 6, 2024
Member
dbanck
left a comment
dbanck
left a comment
There was a problem hiding this comment.
Sounds reasonable and pragmatic to me. And it looks like most of the changes for the alpha are in the /v2 version of the API, so they shouldn't affect us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was originally hoping that there would be a stable version of that library released which we can upgrade to, it does not seem to be coming any time soon. To be fair, we have been consuming untagged revisions for some time before.
On the other hand, we've been getting considerable noise in various places due to security scanners. I do not see an angle in which the vulnerability https://github.com/hashicorp/hc-install/security/dependabot/7 / GHSA-9763-4f94-gfch could impact this project (we don't use Kyber).
All that said, it seems to be worth the trade-offs to simply bump the dependency to the latest alpha version to suppress the noise here and anywhere in downstream libraries which consume this one.