github/release: Ensure production workflow doesn't start before staging#170
Merged
radeksimko merged 1 commit intomainfrom Dec 18, 2023
Merged
github/release: Ensure production workflow doesn't start before staging#170radeksimko merged 1 commit intomainfrom
radeksimko merged 1 commit intomainfrom
Conversation
kmoe
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
productionpromotion is gated by human approval and AFAICT does not requirestagingto actually finish the promotion before it gets to the approval point.However, it still doesn't make much sense to even attempt to promote artifacts in staging to production before the promotion to staging has actually finished.
Admittedly this change won't actually fully achieve that, because as the command name suggests, it only triggers the promotion (i.e. won't wait for completion of the promotion). We can at least avoid triggering production promotion if the triggering the staging promotion fails though.