ensure we finish reading stderr pipe before calling cmd.Wait()#118
Merged
jbardin merged 1 commit intohashicorp:masterfrom Jun 10, 2019
Merged
ensure we finish reading stderr pipe before calling cmd.Wait()#118jbardin merged 1 commit intohashicorp:masterfrom
jbardin merged 1 commit intohashicorp:masterfrom
Conversation
Signed-off-by: Steve Kriss <[email protected]>
|
|
Contributor
Author
|
FYI, I let this run overnight in a daemon process and can confirm I'm no longer getting the error from #116. |
Contributor
Author
|
@jbardin just pinging on this, thanks :) |
Contributor
Author
|
Another ping on this @jbardin. |
Member
|
Sorry about the delay @skriss, we've been tied up with the terraform side of things. |
Contributor
Author
|
No worries, I figured :) Thanks! |
jbardin
approved these changes
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss [email protected]
Fixes #116
cc @jbardin