Skip to content

fix for , non presence of consul-version meta (#18464)#18561

Merged
david-yu merged 1 commit intorelease/1.16.xfrom
node-ui-fix-pr
Aug 23, 2023
Merged

fix for , non presence of consul-version meta (#18464)#18561
david-yu merged 1 commit intorelease/1.16.xfrom
node-ui-fix-pr

Conversation

@david-yu
Copy link
Copy Markdown
Contributor

Description

Manual backport of #18464

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

* fix for #18406 , non presence of consul-version meta

* removed redundant checks

* updated mock-api to mimic api response for synthetic nodes

* added test to test getDistinctConsulVersions method with synthetic-node case

* updated typo in comments

* added change log
@david-yu david-yu merged commit 9026012 into release/1.16.x Aug 23, 2023
@david-yu david-yu deleted the node-ui-fix-pr branch August 23, 2023 15:34
asheshvidyut pushed a commit that referenced this pull request Sep 4, 2023
…to release/1.16.x (#18520)

resolve conflict

Co-authored-by: temp <[email protected]>

Backport of bug: prevent go routine leakage due to existing DeferCheck into release/1.16.x (#18565)

* backport of commit 06d4c72

* backport of commit 42c37bb

---------

Co-authored-by: cskh <[email protected]>

fix for , non presence of consul-version meta (#18464) (#18561)

* fix for #18406 , non presence of consul-version meta

Co-authored-by: Vijay <[email protected]>

[BACKPORT] 1.16.x manual backport of OSS->CE branch (#18549)

Backport of NET-5382 & PLAT-1159: Do not trigger workflow if only doc files are in commit history into release/1.16.x (#18570)

backport of commit c833fcc

Co-authored-by: NiniOak <[email protected]>

Backport of docs: Fix spelling errors across various pages on the site into release/1.16.x (#18537)

docs: Fix spelling errors across various pages on the site (#18533)

This commit fixes numerous spelling errors across the site and also
removes unnecessary whitespace that was present in the edited files.

Co-authored-by: Blake Covarrubias <[email protected]>

Backport of Fix broken link on sameness group page into release/1.16.x (#18588)

backport of commit 05dd1a8

Co-authored-by: Tu Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport theme/ui Anything related to the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants