replaced ordered list of rate limit ops with flow diagram#18398
replaced ordered list of rate limit ops with flow diagram#18398trujillo-adam merged 9 commits intomainfrom
Conversation
trujillo-adam
added
type/docs
…p/consul into docs/add-rate-limit-ops-diagram
| You can define request rate limits in the agent configuration and in the control plane request limit configuration entry. The configuration entry also supports rate limit configurations for Consul resources. Consul performs the following order of operations when determing request rate limits: | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
i think the dark mode coloring is kinda off?
There was a problem hiding this comment.
Hmm, OK. I'll have another look -- this is just how the slides spit it out
There was a problem hiding this comment.
I think I was actually using the wrong the slides --- we don't have the ability to do portrait, so I made a copy (of the wrong slides) and followed the instructions there.
boruszak
left a comment
boruszak
left a comment
There was a problem hiding this comment.
Minor suggestions in this review, otherwise LGTM.
Re: the color of the diagram - looking at this slide in our toolkit - you're using the kit's grey text for labels, which is correct in how it describes labels for boxes - I think it looks weird because the grey is meant to be a secondary color - and without white text there's no primary.
Even though the text is inside boxes, try changing it to white (keep boxes and line work grey). That should improve it.
Co-authored-by: Jeff Boruszak <[email protected]>
Description
This PR replaces the ordered list used to describe the order of operations for determining agent rate limits with a diagram. It includes light and dark mode versions of the diagram. I commented out the list instead of deleting it in case we wanted to revert.
PR Checklist