Skip to content

mesh: adding the protobuf types and resources backing mesh config v2#18351

Merged
rboyer merged 1 commit intomainfrom
rboyer/meshconfig-types
Aug 3, 2023
Merged

mesh: adding the protobuf types and resources backing mesh config v2#18351
rboyer merged 1 commit intomainfrom
rboyer/meshconfig-types

Conversation

@rboyer
Copy link
Copy Markdown
Member

@rboyer rboyer commented Aug 1, 2023 •
edited
Loading

Description

This registers the following new resources:

  • pbcatalog
    • FailoverPolicy
  • pbmesh
    • HTTPRoute
    • GRPCRoute
    • TCPRoute
    • DestinationPolicy
    • ComputedRoutes

It also adds an unused filter field to the catalog workload selector.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

NET-5050

@rboyer rboyer added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test pr/no-backport labels Aug 1, 2023
@rboyer rboyer requested a review from ishustava August 1, 2023 22:06
@rboyer rboyer self-assigned this Aug 1, 2023
ishustava
ishustava reviewed Aug 1, 2023
View reviewed changes
internal/catalog/internal/types/failover_policy.go Outdated
Comment on lines 30 to 31
Copy link
Copy Markdown
Contributor

@ishustava ishustava Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACLs, validation etc will come in a later PR right?

Copy link
Copy Markdown
Member Author

@rboyer rboyer Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This was done to make the PR a mostly boring plumbing PR.

proto-public/pbmesh/v1alpha1/http_route.proto Outdated
Copy link
Copy Markdown
Contributor

@ishustava ishustava Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a blocker at all, but I thought I'll ask here. Should we think about how to run GAMMA conformance tests against these to make sure we stay compliant or even to check if these are compliant? Maybe something we should track somewhere as a deliverable

@rboyer rboyer requested a review from ishustava August 2, 2023 16:26
@rboyer rboyer force-pushed the rboyer/meshconfig-types branch from f9997a9 to 6108263 Compare August 3, 2023 16:59
@rboyer rboyer merged commit 9c227e2 into main Aug 3, 2023
@rboyer rboyer deleted the rboyer/meshconfig-types branch August 3, 2023 18:42
asheshvidyut added a commit that referenced this pull request Sep 4, 2023
@hc-github-team-consul-core @nathancoleman
@natemollica-nm @loshz @jm96441n @beautifulentropy @trujillo-adam @jmurret @Ranjandas @roncodingenthusiast @hashi-derek @asheshvidyut @im2nguyen @xwa153 @cthain @boruszak @evanphx @JadhavPoonam @DanStough @karras @jcjones @fulviodenza @krastin @david3a @curtbushko @nfi-hashicorp @t-davies @lkysow @vijayraghav-io @jkirschner-hashicorp @eddie-rowe @nv-hashi @ishustava @Jeff-Apple @huikang @cocolavayen @joselo85 @rboyer @freddygv @NiniOak @zalimeni @analogue @hashicorp-tsccr @blake @iberlot @ezfepo @ndhanushkodi @jjacobson93 @lornasong @judithpatudith @gautambaghel @apollo13 @cuishuang @johnlanda @Achooo @ilpianista @mkeeler @sarahalsmiller @hashicorp-copywrite @boxofrad @natmegs @hdkshingala
Backport of NET 1594 - Snapshot Agent Filename Should Include Consul …
332ba62 
…Version / Datacenter into release/1.15.x (#18639)

* Reference hashicorp/consul instead of consul for Docker image (#17914)

* Reference hashicorp/consul instead of consul for Docker image

* Update Make targets that pull consul directly

* Update Consul K8s Upgrade Doc Updates (#17921)

Updating upgrade procedures to encompass expected errors during upgrade process from v1.13.x to v1.14.x.

* Update sameness-group.mdx (#17915)

* Update create-sameness-groups.mdx (#17927)

* deps: coredns v1.10.1 (#17912)

* Ensure RSA keys are at least 2048 bits in length (#17911)

* Ensure RSA keys are at least 2048 bits in length

* Add changelog

* update key length check for FIPS compliance

* Fix no new variables error and failing to return when error exists from
validating

* clean up code for better readability

* actually return value

* tlsutil: Fix check TLS configuration (#17481)

* tlsutil: Fix check TLS configuration
* Rewording docs.
* Update website/content/docs/services/configuration/checks-configuration-reference.mdx
Co-authored-by: trujillo-adam <[email protected]>
* Fix typos and add changelog entry.
---------

Co-authored-by: trujillo-adam <[email protected]>

* docs: Deprecations for connect-native SDK and specific connect native APIs (#17937)

* Update v1_16_x.mdx
* Update connect native golang page

---------

Co-authored-by: trujillo-adam <[email protected]>

* Revert "Add workflow to verify linux release packages (#17904)" (#17942)

This reverts commit 3368f14fab500ebe9f6aeab5631dd1d5f5a453e5.

* Fixes Secondary ConnectCA update (#17846)

This fixes a bug that was identified which resulted in subsequent
ConnectCA configuration update not to persist in the cluster.

* fixing typo in link to jwt-validations-with-intentions doc (#17955)

* Fix streaming backend link (#17958)

* Fix streaming backend link
* Update health.mdx

* Dynamically create jwks clusters for jwt-providers (#17944)

* website: remove deprecated agent rpc docs (#17962)

* Fix missing BalanceOutboundConnections in v2 catalog. (#17964)

* feature - [NET - 4005]  - [Supportability] Reloadable Configuration - enable_debug (#17565)

* # This is a combination of 9 commits.
# This is the 1st commit message:

init without tests

# This is the commit message #2:

change log

# This is the commit message #3:

fix tests

# This is the commit message #4:

fix tests

# This is the commit message #5:

added tests

# This is the commit message #6:

change log breaking change

# This is the commit message #7:

removed breaking change

# This is the commit message #8:

fix test

# This is the commit message #9:

keeping the test behaviour same

* # This is a combination of 12 commits.
# This is the 1st commit message:

init without tests

# This is the commit message #2:

change log

# This is the commit message #3:

fix tests

# This is the commit message #4:

fix tests

# This is the commit message #5:

added tests

# This is the commit message #6:

change log breaking change

# This is the commit message #7:

removed breaking change

# This is the commit message #8:

fix test

# This is the commit message #9:

keeping the test behaviour same

# This is the commit message #10:

made enable debug atomic bool

# This is the commit message #11:

fix lint

# This is the commit message #12:

fix test true enable debug

* parent 10f500e895d92cc3691ade7b74a33db755d22039
author absolutelightning <[email protected]> 16873