Skip to content

[NET-5121] proxystate: move protos to subdirectory to avoid conflicts#18335

Merged
ndhanushkodi merged 1 commit intomainfrom
nd/net-5121-ir-protos-subdir
Aug 1, 2023
Merged

[NET-5121] proxystate: move protos to subdirectory to avoid conflicts#18335
ndhanushkodi merged 1 commit intomainfrom
nd/net-5121-ir-protos-subdir

Conversation

@ndhanushkodi
Copy link
Copy Markdown
Contributor

@ndhanushkodi ndhanushkodi commented Aug 1, 2023 •
edited
Loading

  • also makes some updates to protos

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@ndhanushkodi ndhanushkodi added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. pr/no-backport labels Aug 1, 2023
@ndhanushkodi ndhanushkodi force-pushed the nd/net-5121-ir-protos-subdir branch 2 times, most recently from 3ee4eab to d83c21d Compare August 1, 2023 06:07
@ndhanushkodi ndhanushkodi force-pushed the nd/net-5121-ir-protos-subdir branch from d83c21d to acda93d Compare August 1, 2023 06:11
DanStough
DanStough approved these changes Aug 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

rboyer
rboyer reviewed Aug 1, 2023
View reviewed changes
proto-public/pbmesh/v1alpha1/proxy_state.proto Outdated

// required_endpoints is a map of arbitrary string names to endpoint refs that need fetching by the proxy state controller.
map<string, EndpointRef> required_endpoints = 2;
map<string, hashicorp.consul.mesh.v1alpha1.pbproxystate.EndpointRef> required_endpoints = 2;
Copy link
Copy Markdown
Member

@rboyer rboyer Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are in a subdirectory, I wonder if you can just refer to them as pbproxystate.EndpointRef and the compiler will know how to find it?

Copy link
Copy Markdown
Contributor Author

@ndhanushkodi ndhanushkodi Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice it looks like that works! I'll update

rboyer
rboyer approved these changes Aug 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor non-blocking suggestion.

@ndhanushkodi ndhanushkodi force-pushed the nd/net-5121-ir-protos-subdir branch from acda93d to 2a96d80 Compare August 1, 2023 17:11
@ndhanushkodi ndhanushkodi force-pushed the nd/net-5121-ir-protos-subdir branch from 2a96d80 to 68d7b74 Compare August 1, 2023 17:12
@ndhanushkodi ndhanushkodi enabled auto-merge (squash) August 1, 2023 17:19
@ndhanushkodi ndhanushkodi merged commit e459399 into main Aug 1, 2023
@ndhanushkodi ndhanushkodi deleted the nd/net-5121-ir-protos-subdir branch August 1, 2023 17:35
asheshvidyut added a commit that referenced this pull request Sep 4, 2023
@hc-github-team-consul-core @nathancoleman
@natemollica-nm @loshz @jm96441n @beautifulentropy @trujillo-adam @jmurret @Ranjandas @roncodingenthusiast @hashi-derek @asheshvidyut @im2nguyen @xwa153 @cthain @boruszak @evanphx @JadhavPoonam @DanStough @karras @jcjones @fulviodenza @krastin @david3a @curtbushko @nfi-hashicorp @t-davies @lkysow @vijayraghav-io @jkirschner-hashicorp @eddie-rowe @nv-hashi @ishustava @Jeff-Apple @huikang @cocolavayen @joselo85 @rboyer @freddygv @NiniOak @zalimeni @analogue @hashicorp-tsccr @blake @iberlot @ezfepo @ndhanushkodi @jjacobson93 @lornasong @judithpatudith @gautambaghel @apollo13 @cuishuang @johnlanda @Achooo @ilpianista @mkeeler @sarahalsmiller @hashicorp-copywrite @boxofrad @natmegs @hdkshingala
Backport of NET 1594 - Snapshot Agent Filename Should Include Consul …
332ba62 
…Version / Datacenter into release/1.15.x (#18639)

* Reference hashicorp/consul instead of consul for Docker image (#17914)

* Reference hashicorp/consul instead of consul for Docker image

* Update Make targets that pull consul directly

* Update Consul K8s Upgrade Doc Updates (#17921)

Updating upgrade procedures to encompass expected errors during upgrade process from v1.13.x to v1.14.x.

* Update sameness-group.mdx (#17915)

* Update create-sameness-groups.mdx (#17927)

* deps: coredns v1.10.1 (#17912)

* Ensure RSA keys are at least 2048 bits in length (#17911)

* Ensure RSA keys are at least 2048 bits in length

* Add changelog

* update key length check for FIPS compliance

* Fix no new variables error and failing to return when error exists from
validating

* clean up code for better readability

* actually return value

* tlsutil: Fix check TLS configuration (#17481)

* tlsutil: Fix check TLS configuration
* Rewording docs.
* Update website/content/docs/services/configuration/checks-configuration-reference.mdx
Co-authored-by: trujillo-adam <[email protected]>
* Fix typos and add changelog entry.
---------

Co-authored-by: trujillo-adam <[email protected]>

* docs: Deprecations for connect-native SDK and specific connect native APIs (#17937)

* Update v1_16_x.mdx
* Update connect native golang page

---------

Co-authored-by: trujillo-adam <[email protected]>

* Revert "Add workflow to verify linux release packages (#17904)" (#17942)

This reverts commit 3368f14fab500ebe9f6aeab5631dd1d5f5a453e5.

* Fixes Secondary ConnectCA update (#17846)

This fixes a bug that was identified which resulted in subsequent
ConnectCA configuration update not to persist in the cluster.

* fixing typo in link to jwt-validations-with-intentions doc (#17955)

* Fix streaming backend link (#17958)

* Fix streaming backend link
* Update health.mdx

* Dynamically create jwks clusters for jwt-providers (#17944)

* website: remove deprecated agent rpc docs (#17962)

* Fix missing BalanceOutboundConnections in v2 catalog. (#17964)

* feature - [NET - 4005]  - [Supportability] Reloadable Configuration - enable_debug (#17565)

* # This is a combination of 9 commits.
# This is the 1st commit message:

init without tests

# This is the commit message #2:

change log

# This is the commit message #3:

fix tests

# This is the commit message #4:

fix tests

# This is the commit message #5:

added tests

# This is the commit message #6:

change log breaking change

# This is the commit message #7:

removed breaking change

# This is the commit message #8:

fix test

# This is the commit message #9:

keeping the test behaviour same

* # This is a combination of 12 commits.
# This is the 1st commit message:

init without tests

# This is the commit message #2:

change log

# This is the commit message #3:

fix tests

# This is the commit message #4:

fix tests

# This is the commit message #5:

added tests

# This is the commit message #6:

change log breaking change

# This is the commit message #7:

removed breaking change

# This is the commit message #8:

fix test

# This is the commit message #9:

keeping the test behaviour same

# This is the commit message #10:

made enable debug atomic bool

# This is the commit message #11:

fix lint

# This is the commit message #12:

fix test true enable debug

* parent 10f500e895d92cc3691ade7b74a33db755d22039
author absolutelightning <[email protected]> 1687352587 +0530
committer absolutelightning <[email protected]> 1687352592 +0530

init without tests

change log

fix tests

fix tests

added tests

change log breaking change

removed breaking change

fix test

keeping the test behaviour same

made enable debug atomic bool

fix lint

fix test true enable debug

using enable debug in agent as atomic bool

test fixes

fix tests

fix tests

added update on correct locaiton

fix tests

fix reloa