Skip to content

NET-4240 - Snapshots are failing on Windows #18302

Merged
asheshvidyut merged 7 commits intomainfrom
NET-4240
Aug 2, 2023
Merged

NET-4240 - Snapshots are failing on Windows #18302
asheshvidyut merged 7 commits intomainfrom
NET-4240

Conversation

@asheshvidyut
Copy link
Copy Markdown
Contributor

@asheshvidyut asheshvidyut commented Jul 27, 2023

Description

Updates version of rboyer/safeio#3 to github.com/rboyer/safeio v0.2.3. To fix snapshot save in windows. More description here - rboyer/safeio#3

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the pr/dependencies PR specifically updates dependencies of project label Jul 27, 2023
@asheshvidyut
Copy link
Copy Markdown
Contributor Author

asheshvidyut commented Jul 27, 2023

@david-yu please let me know what backports needs to be added. Thanks.

@asheshvidyut asheshvidyut requested a review from rboyer July 27, 2023 04:54
@asheshvidyut asheshvidyut changed the title fix go mod NET-4240 - Snapshots are failing on Windows Jul 27, 2023
@david-yu david-yu added backport/1.14 backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. labels Jul 27, 2023
@david-yu
Copy link
Copy Markdown
Contributor

david-yu commented Jul 27, 2023

Added 1.14.x-1.16.x for backports since the customer is on an older version. @absolutelightning could you also include a changelog?

@asheshvidyut
Copy link
Copy Markdown
Contributor Author

asheshvidyut commented Jul 31, 2023 •
edited
Loading

@rboyer https://github.com/hashicorp/consul/actions/runs/5698317283/job/15480946596?pr=18302
Can you help why is this failing? I ran go mod tidy on local but nothing changed.

@rboyer
Copy link
Copy Markdown
Member

rboyer commented Jul 31, 2023

Did you try make go-mod-tidy in the root? We have a wrapper that makes sure to update the myriad of go.mod files through the repo in the right order.

@asheshvidyut asheshvidyut merged commit 67fc93e into main Aug 2, 2023
@asheshvidyut asheshvidyut deleted the NET-4240 branch August 2, 2023 02:44
This was referenced Aug 2, 2023
Merged
Merged
Merged
@chenrui333 chenrui333 mentioned this pull request Aug 9, 2023
Merged
asheshvidyut added a commit that referenced this pull request Sep 4, 2023
@hc-github-team-consul-core @nathancoleman
@natemollica-nm @loshz @jm96441n @beautifulentropy @trujillo-adam @jmurret @Ranjandas @roncodingenthusiast @hashi-derek @asheshvidyut @im2nguyen @xwa153 @cthain @boruszak @evanphx @JadhavPoonam @DanStough @karras @jcjones @fulviodenza @krastin @david3a @curtbushko @nfi-hashicorp @t-davies @lkysow @vijayraghav-io @jkirschner-hashicorp @eddie-rowe @nv-hashi @ishustava @Jeff-Apple @huikang @cocolavayen @joselo85 @rboyer @freddygv @NiniOak @zalimeni @analogue @hashicorp-tsccr @blake @iberlot @ezfepo @ndhanushkodi @jjacobson93 @lornasong @judithpatudith @gautambaghel @apollo13 @cuishuang @johnlanda @Achooo @ilpianista @mkeeler @sarahalsmiller @hashicorp-copywrite @boxofrad @natmegs @hdkshingala
Backport of NET 1594 - Snapshot Agent Filename Should Include Consul …
332ba62 
…Version / Datacenter into release/1.15.x (#18639)

* Reference hashicorp/consul instead of consul for Docker image (#17914)

* Reference hashicorp/consul instead of consul for Docker image

* Update Make targets that pull consul directly

* Update Consul K8s Upgrade Doc Updates (#17921)

Updating upgrade procedures to encompass expected errors during upgrade process from v1.13.x to v1.14.x.

* Update sameness-group.mdx (#17915)

* Update create-sameness-groups.mdx (#17927)

* deps: coredns v1.10.1 (#17912)

* Ensure RSA keys are at least 2048 bits in length (#17911)

* Ensure RSA keys are at least 2048 bits in length

* Add changelog

* update key length check for FIPS compliance

* Fix no new variables error and failing to return when error exists from
validating

* clean up code for better readability

* actually return value

* tlsutil: Fix check TLS configuration (#17481)

* tlsutil: Fix check TLS configuration
* Rewording docs.
* Update website/content/docs/services/configuration/checks-configuration-reference.mdx
Co-authored-by: trujillo-adam <[email protected]>
* Fix typos and add changelog entry.
---------

Co-authored-by: trujillo-adam <[email protected]>

* docs: Deprecations for connect-native SDK and specific connect native APIs (#17937)

* Update v1_16_x.mdx
* Update connect native golang page

---------

Co-authored-by: trujillo-adam <[email protected]>

* Revert "Add workflow to verify linux release packages (#17904)" (#17942)

This reverts commit 3368f14fab500ebe9f6aeab5631dd1d5f5a453e5.

* Fixes Secondary ConnectCA update (#17846)

This fixes a bug that was identified which resulted in subsequent
ConnectCA configuration update not to persist in the cluster.

* fixing typo in link to jwt-validations-with-intentions doc (#17955)

* Fix streaming backend link (#17958)

* Fix streaming backend link
* Update health.mdx

* Dynamically create jwks clusters for jwt-providers (#17944)

* website: remove deprecated agent rpc docs (#17962)

* Fix missing BalanceOutboundConnections in v2 catalog. (#17964)

* feature - [NET - 4005]  - [Supportability] Reloadable Configuration - enable_debug (#17565)

* # This is a combination of 9 commits.
# This is the 1st commit message:

init without tests

# This is the commit message #2:

change log

# This is the commit message #3:

fix tests

# This is the commit message #4:

fix tests

# This is the commit message #5:

added tests

# This is the commit message #6:

change log breaking change

# This is the commit message #7:

removed breaking change

# This is the commit message #8:

fix test

# This is the commit message #9:

keeping the test behaviour same

* # This is a combination of 12 commits.
# This is the 1st commit message:

init without tests

# This is the commit message #2:

change log

# This is the commit message #3:

fix tests

# This is the commit message #4:

fix tests

# This is the commit message #5:

added tests

# This is the commit message