Skip to content

[CC-5718] Remove HCP token requirement during bootstrap#18140

Merged
jjacobson93 merged 6 commits intomainfrom
jer/ccm-read-only
Jul 21, 2023
Merged

[CC-5718] Remove HCP token requirement during bootstrap#18140
jjacobson93 merged 6 commits intomainfrom
jer/ccm-read-only

Conversation

@jjacobson93
Copy link
Copy Markdown
Contributor

@jjacobson93 jjacobson93 commented Jul 14, 2023 •
edited
Loading

Description

We are removing the requirement for HCP to provide Consul with a management token to support read-only tokens. This changes the validations to allow for a management token to be missing/ignored during bootstrapping with HCP.

Links

Ticket
RFC

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jjacobson93 jjacobson93 requested a review from lornasong July 17, 2023 18:58
lornasong
lornasong reviewed Jul 17, 2023
View reviewed changes
@jjacobson93 jjacobson93 added backport/1.14 backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. labels Jul 19, 2023
lornasong
lornasong approved these changes Jul 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! left two suggestions

@jjacobson93 jjacobson93 requested a review from loshz July 20, 2023 21:00
@jjacobson93 jjacobson93 merged commit 6671d7e into main Jul 21, 2023
@jjacobson93 jjacobson93 deleted the jer/ccm-read-only branch July 21, 2023 17:33
This was referenced Jul 21, 2023
Closed
Closed
Merged
@loshz loshz mentioned this pull request Jul 26, 2023
Merged
4 tasks
@jjacobson93 jjacobson93 mentioned this pull request Jul 26, 2023
Merged
4 tasks
@jmurret jmurret removed backport/1.14 backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. labels Aug 3, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 9, 2023
Merged
asheshvidyut added a commit that referenced this pull request Sep 4, 2023
@hc-github-team-consul-core @nathancoleman
@natemollica-nm @loshz @jm96441n @beautifulentropy @trujillo-adam @jmurret @Ranjandas @roncodingenthusiast @hashi-derek @asheshvidyut @im2nguyen @xwa153 @cthain @boruszak @evanphx @JadhavPoonam @DanStough @karras @jcjones @fulviodenza @krastin @david3a @curtbushko @nfi-hashicorp @t-davies @lkysow @vijayraghav-io @jkirschner-hashicorp @eddie-rowe @nv-hashi @ishustava @Jeff-Apple @huikang @cocolavayen @joselo85 @rboyer @freddygv @NiniOak @zalimeni @analogue @hashicorp-tsccr @blake @iberlot @ezfepo @ndhanushkodi @jjacobson93 @lornasong @judithpatudith @gautambaghel @apollo13 @cuishuang @johnlanda @Achooo @ilpianista @mkeeler @sarahalsmiller @hashicorp-copywrite @boxofrad @natmegs @hdkshingala