Skip to content

Expose JWKS cluster config through JWTProviderConfigEntry#17978

Merged
roncodingenthusiast merged 4 commits intomainfrom
issue-17886-expose-certs
Jul 4, 2023
Merged

Expose JWKS cluster config through JWTProviderConfigEntry#17978
roncodingenthusiast merged 4 commits intomainfrom
issue-17886-expose-certs

Conversation

@roncodingenthusiast
Copy link
Copy Markdown
Contributor

@roncodingenthusiast roncodingenthusiast commented Jun 30, 2023

Description

  • Expose remote jwks cluster configuration through jwt-provider config entry to allow users to configure how remote jwks uri s are obtained.
  • We are starting with certs and connect timeout as we deem those are the most important ones currently. We will be adding more fields as we find the demand for this

Testing & Reproduction steps

  • write a jwt provider with jwks cluster
  • get the envoy config dump to ensure the cluster being configured has the right values

TODO

  • follow up this PR with docs

@roncodingenthusiast roncodingenthusiast added the backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. label Jun 30, 2023
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/envoy/xds Related to Envoy support labels Jun 30, 2023
@roncodingenthusiast roncodingenthusiast force-pushed the issue-17886-expose-certs branch from b3628cd to 8a8a8c4 Compare June 30, 2023 15:55
@roncodingenthusiast roncodingenthusiast requested review from a team, kisunji, pglass and skpratt and removed request for a team June 30, 2023 15:57
@roncodingenthusiast roncodingenthusiast marked this pull request as ready for review June 30, 2023 15:57
@roncodingenthusiast roncodingenthusiast force-pushed the issue-17886-expose-certs branch from 8a8a8c4 to 34b3f87 Compare June 30, 2023 16:00
johnlanda
johnlanda reviewed Jun 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnlanda johnlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comment fixes to make them full sentences / with punctuation.

A few minor questions on some duplicated consts.

johnlanda
johnlanda approved these changes Jul 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnlanda johnlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roncodingenthusiast roncodingenthusiast merged commit 8039427 into main Jul 4, 2023
@roncodingenthusiast roncodingenthusiast deleted the issue-17886-expose-certs branch July 4, 2023 13:12
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Jul 4, 2023
Closed
1 task
@roncodingenthusiast
Copy link
Copy Markdown
Contributor Author

roncodingenthusiast commented Jul 4, 2023

Linking #17886

roncodingenthusiast added a commit that referenced this pull request Jul 4, 2023
@roncodingenthusiast
Expose JWKS cluster config through JWTProviderConfigEntry (#17978)
ba4a67f 
* Expose JWKS cluster config through JWTProviderConfigEntry

* fix typos, rename trustedCa to trustedCA
@roncodingenthusiast roncodingenthusiast mentioned this pull request Jul 4, 2023
Merged
1 task
roncodingenthusiast added a commit that referenced this pull request Jul 4, 2023
@roncodingenthusiast
Expose JWKS cluster config through JWTProviderConfigEntry (#17978) (#…
7408c14 
…18002)

* Expose JWKS cluster config through JWTProviderConfigEntry

* fix typos, rename trustedCa to trustedCA
@roncodingenthusiast roncodingenthusiast mentioned this pull request Jul 4, 2023
Merged
roncodingenthusiast added a commit that referenced this pull request Jul 14, 2023
@roncodingenthusiast
Add docs for jwt cluster configuration (#18004)
2229206 
### Description

<!-- Please describe why you're making this change, in plain English.
-->

- Add jwt-provider docs for jwks cluster configuration. The
configuration was added here:
#17978
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Jul 14, 2023
Merged
hc-github-team-consul-core added a commit that referenced this pull request Jul 14, 2023
@hc-github-team-consul-core @roncodingenthusiast
Backport of Add docs for jwt cluster configuration into release/1.16.x (
a5c713a 
#18135)

## Backport

This PR is auto-generated from #18004 to be assessed for backporting due
to the inclusion of the label backport/1.16.



The below text is copied from the body of the original PR.

---

### Description

<!-- Please describe why you're making this change, in plain English.
-->

- Add jwt-provider docs for jwks cluster configuration. The
configuration was added here:
#17978


---

<details>
<summary> Overview of commits </summary>

  - 1ab3c3b 

</details>

Co-authored-by: Ronald Ekambi <[email protected]>
hc-github-team-consul-core added a commit that referenced this pull request Jul 21, 2023
@hc-github-team-consul-core @zalimeni
@roncodingenthusiast @erichaberkorn @lkysow @rboyer @trujillo-adam @boruszak @mkeeler @nathancoleman @JadhavPoonam @im2nguyen @cthain @ramramhariram @sfarkas-hashicorp @Jeff-Apple @asheshvidyut @DanStough @curtbushko @tcraxs @jkirschner-hashicorp @analogue @dependabot @chapmanc @hashi-derek @jmurret @markcampv @boxofrad @stevenzamborsky @gbolo @xwa153 @huikang @cn0047 @ishustava @shamil @loshz @sarahalsmiller @mr-miles @natemollica-nm @jm96441n @beautifulentropy @Ranjandas @evanphx @karras @jcjones @fulviodenza @jjacobson93