Skip to content

feat: include nodes count in operator usage endpoint and cli command#17939

Merged
JadhavPoonam merged 2 commits intomainfrom
NET-3491/nodes-usgae-endpoint
Jul 5, 2023
Merged

feat: include nodes count in operator usage endpoint and cli command#17939
JadhavPoonam merged 2 commits intomainfrom
NET-3491/nodes-usgae-endpoint

Conversation

@JadhavPoonam
Copy link
Copy Markdown
Contributor

@JadhavPoonam JadhavPoonam commented Jun 28, 2023

Description

Enhances the operator/usage API endpoint and the corresponding CLI command to include node count in the output.

Testing & Reproduction steps

Tested in dev mode

API

Screenshot 2023-06-28 at 4 26 37 PM

CLI
Screenshot 2023-06-29 at 4 36 50 PM

Links

API doc: https://developer.hashicorp.com/consul/api-docs/operator/usage

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jun 28, 2023
@JadhavPoonam JadhavPoonam force-pushed the NET-3491/nodes-usgae-endpoint branch 2 times, most recently from b9449be to cb715c0 Compare June 28, 2023 19:52
@JadhavPoonam JadhavPoonam force-pushed the NET-3491/nodes-usgae-endpoint branch from cb715c0 to 1902a23 Compare June 28, 2023 20:38
@JadhavPoonam JadhavPoonam changed the title feat: wip feat: include nodes count in operator usage endpoint and cli command Jun 28, 2023
@JadhavPoonam JadhavPoonam requested a review from dhiaayachi June 28, 2023 20:48
@JadhavPoonam JadhavPoonam force-pushed the NET-3491/nodes-usgae-endpoint branch from 1902a23 to 18ada75 Compare June 28, 2023 20:56
@JadhavPoonam JadhavPoonam force-pushed the NET-3491/nodes-usgae-endpoint branch 3 times, most recently from 7b6bfbf to 5ab59f5 Compare June 29, 2023 21:17
@JadhavPoonam JadhavPoonam added the pr/no-changelog PR does not need a corresponding .changelog entry label Jun 29, 2023
@JadhavPoonam JadhavPoonam marked this pull request as ready for review June 29, 2023 21:19
@JadhavPoonam JadhavPoonam requested a review from a team as a code owner June 29, 2023 21:19
@JadhavPoonam JadhavPoonam requested a review from a team June 29, 2023 21:19
Copy link
Copy Markdown
Contributor

@loshz loshz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Copy Markdown
Contributor

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Great work @JadhavPoonam! I left a small question but nothing blocking.

@JadhavPoonam JadhavPoonam force-pushed the NET-3491/nodes-usgae-endpoint branch from 5ab59f5 to e543f71 Compare July 4, 2023 18:34
Copy link
Copy Markdown
Contributor

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog ✅

@im2nguyen im2nguyen added backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. and removed pr/no-backport labels Jul 5, 2023
@JadhavPoonam JadhavPoonam merged commit 8af4ad1 into main Jul 5, 2023
@JadhavPoonam JadhavPoonam deleted the NET-3491/nodes-usgae-endpoint branch July 5, 2023 15:23
hc-github-team-consul-core added a commit that referenced this pull request Jul 21, 2023
…nto release/1.16.x (#18229)

* [OSS] Post Consul 1.16 updates (#17606)

* chore: update dev build to 1.17

* chore(ci): add nightly 1.16 test

Drop the oldest and add the newest running release branch to nightly
builds.

* Add writeAuditRPCEvent to agent_oss (#17607)

* Add writeAuditRPCEvent to agent_oss

* fix the other diffs

* backport change log

* Add Envoy and Consul version constraints to Envoy extensions (#17612)

* [API Gateway] Fix trust domain for external peered services in synthesis code (#17609)

* [API Gateway] Fix trust domain for external peered services in synthesis code

* Add changelog

* backport ent changes to oss (#17614)

* backport ent changes to oss

* Update .changelog/_5669.txt

Co-authored-by: Michael Zalimeni <[email protected]>

---------

Co-authored-by: Michael Zalimeni <[email protected]>

* Update intentions.mdx (#17619)

Make behaviour of L7 intentions clearer

* enterprise changelog update for audit (#17625)

* Update list of Envoy versions (#17546)

* [API Gateway] Fix rate limiting for API gateways (#17631)

* [API Gateway] Fix rate limiting for API gateways

* Add changelog

* Fix failing unit tests

* Fix operator usage tests for api package

* sort some imports that are wonky between oss and ent (#17637)

* PmTLS and tproxy improvements with failover and L7 traffic mgmt for k8s (#17624)

* porting over changes from enterprise repo to oss

* applied feedback on service mesh for k8s overview

* fixed typo

* removed ent-only build script file

* Apply suggestions from code review

Co-authored-by: Jeff Boruszak <[email protected]>

* Apply suggestions from code review

Co-authored-by: David Yu <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>

---------

Co-authored-by: Jeff Boruszak <[email protected]>
Co-authored-by: David Yu <[email protected]>

* Delete check-legacy-links-format.yml (#17647)

* docs: Reference doc updates for permissive mTLS settings (#17371)

* Reference doc updates for permissive mTLS settings
* Document config entry filtering
* Fix minor doc errors (double slashes in link url paths)

---------

Co-authored-by: trujillo-adam <[email protected]>

* Add generic experiments configuration and use it to enable catalog v2 resources (#17604)

* Add generic experiments configuration and use it to enable catalog v2 resources

* Run formatting with -s as CI will validate that this has been done

* api-gateway: stop adding all header filters to virtual host when generating xDS (#17644)

* Add header filter to api-gateway xDS golden test

* Stop adding all header filters to virtual host when generating xDS for api-gateway

* Regenerate xDS golden file for api-gateway w/ header filter

* fix: add agent info reporting log (#17654)

* Add new Consul 1.16 docs (#17651)

* Merge pull request #5773 from hashicorp/docs/rate-limiting-from-ip-addresses-1.16

updated docs for rate limiting for IP addresses - 1.16

* Merge pull request #5609 from hashicorp/docs/enterprise-utilization-reporting

Add docs for enterprise utilization reporting

* Merge pull request #5734 from hashicorp/docs/envoy-ext-1.16

Docs/envoy ext 1.16

* Merge pull request #5773 from hashicorp/docs/rate-limiting-from-ip-addresses-1.16

updated docs for rate limiting for IP addresses - 1.16

* Merge pull request #5609 from hashicorp/docs/enterprise-utilization-reporting

Add docs for enterprise utilization reporting

* Merge pull request #5734 from hashicorp/docs/envoy-ext-1.16

Docs/envoy ext 1.16

* fix build errors

---------

Co-authored-by: trujillo-adam <[email protected]>

* Default `ProxyType` for builtin extensions (#17657)

* Post 1.16.0-rc1 updates (#17663)

- Update changelog to include new entries from release
- Update submodule versions to latest published

* Update service-defaults.mdx (#17656)

* docs: Sameness Groups (#17628)

* port from enterprise branch

* Apply suggestions from code review

Co-authored-by: shanafarkas <[email protected]>

* Update website/content/docs/connect/cluster-peering/usage/create-sameness-groups.mdx

* next steps

* Update website/content/docs/connect/cluster-peering/usage/create-sameness-groups.mdx

Co-authored-by: trujillo-adam <[email protected]>

* Update website/content/docs/k8s/connect/cluster-peering/usage/create-sameness-groups.mdx

Co-authored-by: trujillo-adam <[email protected]>

---------

Co-authored-by: shanafarkas <[email protected]>
Co-authored-by: trujillo-adam <[email protected]>

* Remove "BETA" marker from config entries (#17670)

* CAPIgw for K8s installation updates for 1.16 (