Backport of Ensure RSA keys are at least 2048 bits in length into release/1.16.x#17935
Merged
jm96441n merged 3 commits intorelease/1.16.xfrom Jun 28, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/NET-4173-rsa-key-length-inline-certs/mainly-diverse-jawfish
branch
from
7a13886 to
fdc6191
Compare
hc-github-team-consul-core
force-pushed
the
backport/NET-4173-rsa-key-length-inline-certs/mainly-diverse-jawfish
branch
from
698c0c7 to
4217bee
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 28, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
…nline-certs/mainly-diverse-jawfish
* Ensure RSA keys are at least 2048 bits in length * Add changelog * update key length check for FIPS compliance * Fix no new variables error and failing to return when error exists from validating * clean up code for better readability * actually return value
jm96441n
deleted the
backport/NET-4173-rsa-key-length-inline-certs/mainly-diverse-jawfish
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17911 to be assessed for backporting due to the inclusion of the label backport/1.16.
🚨
The person who merged in the original PR is:
@jm96441n
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Envoy will silently reject RSA keys that are less than 2048 bits in length. The only way to find a key has been rejected is to go deep into the envoy config to see why. This introduces a change to reject invalid keys earlier and in a more user friendly way.
Testing & Reproduction steps
Links
PR Checklist
Overview of commits
<-- Addresses NET-4404 -->