Backport of ci: fix runner calculation to exclude the top level directory as part of the calculation into release/1.14.x#17110
Merged
jmurret merged 3 commits intorelease/1.14.xfrom Apr 24, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/jm/num-runner/firstly-learning-ladybug
branch
2 times, most recently
from
a9ee516 to
1ca6ce6
Compare
github-actions
bot
added
theme/contributing
github-team-consul-core-pr-approver
approved these changes
Apr 24, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
… of the calculation (#17090) * fix runner calculation to exclude the top level directory as part of the calculation * fix the logic for generating the directories/functions * De-scope tenenacy requirements to OSS only for now. (#17087) Partition and namespace must be "default" Peername must be "local" * Fix virtual services being included in intention topology as downstreams. (#17099) * Merge pull request #5200 from hashicorp/NET-3758 (#17102) * Merge pull request #5200 from hashicorp/NET-3758 NET-3758: connect: update supported envoy versions to 1.26.0 * lint * CI: remove uneeded AWS creds from test-integrations (#17104) * Update test-integrations.yml * removing permission lies now that vault is not used in this job. --------- Co-authored-by: John Murret <[email protected]> * update based on feedback --------- Co-authored-by: Semir Patel <[email protected]> Co-authored-by: Derek Menteer <[email protected]> Co-authored-by: Anita Akaeze <[email protected]> Co-authored-by: Dan Bond <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17090 to be assessed for backporting due to the inclusion of the label backport/1.14.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
When calculating number of runners,
findreports back the top level current directory in addition to the child directories. The actual splitting does not include this top level, so the process hangs. This fix excludes the top level.Description
Testing & Reproduction steps
Links
PR Checklist
Overview of commits