Skip to content

Add publisher listing for mcp.mail-server - #3805

Merged
zerocodefast merged 1 commit into
hashgraph-online:mainfrom
yunfeizhu:codex/mcp-mail-server-publisher-listing
Oct 9, 2026
Merged

zerocodefast merged 1 commit into
hashgraph-online:mainfrom
yunfeizhu:codex/mcp-mail-server-publisher-listing

Conversation

@yunfeizhu

@yunfeizhu yunfeizhu commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

What changed

The mcp.mail-server contribution merged in #3278, but its publisher profile cannot be claimed because it has no accepted numeric GitHub ID mapping. Add contributions/extension-listings/mcp.mail-server.json using guard.extension-listing.v2.

This PR proposes yunfeizhu (verified numeric GitHub ID 12027613) as the authorized publisher-profile manager through maintainerGithubIds. The mapping requires maintainer review and acceptance on canonical main before it can authorize a claim. Public credit is recorded separately in contributors.

Upstream source and version

Capability boundary

This is a publisher metadata change for the existing public contribution ID mcp.mail-server (runtime ID command.mcp-mail-server). The listing describes the existing opt-in deletion-review coverage and its launch-identity limits. It does not change tool policy, activation, runtime trust, or upstream ownership. Only the new listing file is included; generated catalogs and projections remain maintainer-owned.

Fast validation

  • Validated the actual new file with the listing loader, public v2 JSON Schema, existing MCP contribution identity, and claim-notice accepted_github_ids validator.
  • Built the current source compiler with cargo +1.88.0 build --locked --manifest-path rust/Cargo.toml --release -p guard-command --bin guard-command-source.
  • Ran the existing listing and claim-notice tests: 109 passed.
HOL_GUARD_NATIVE_SOURCE_COMPILER="$PWD/rust/target/release/guard-command-source" \
  .venv/bin/pytest tests/test_guard_extension_builder_listing.py \
  tests/test_guard_extension_claim_notice.py -q

Checklist

  • The listing filename and extension ID match the existing MCP contribution.
  • No runtime source, fixtures, trust entries, or generated projections are changed.
  • The listing contains no private email, secrets, executable fields, or inferred claim authority.
  • The explicit numeric-ID mapping is submitted for maintainer review, separately from public attribution.

Summary by CodeRabbit

  • New Integrations
    • Added a listing for the mail-server extension, describing optional review controls for message deletion and when mailbox listing and search may receive automatic allow defaults.
    • Defaults require local administrator enablement and a matching launch identity. Custom grants on this device and stricter Guard policies take precedence; other tools remain subject to host settings.

@greptile-apps

greptile-apps Bot commented Oct 9, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

@github-actions github-actions Bot added the gitar-managed Enables Gitar automatic repair for a pull request label Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e28ddfbd-6896-4751-9faf-5df5e9db36ae
📥 Commits

Reviewing files that changed from the base of the PR and between 6fc83e0 and 2f87bc1.

📒 Files selected for processing (1)
  • contributions/extension-listings/mcp.mail-server.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Adds an extension listing for mcp.mail-server. The listing describes deletion-review coverage, conditions for automatic read allowances, evidence limitations, and project attribution metadata.

Changes

Mail server extension listing

Layer / File(s) Summary
Review and allowance declarations
contributions/extension-listings/mcp.mail-server.json
The listing describes review of delete_message and delete_messages, conditional automatic read allowances, policy precedence, evidence limits, and project metadata.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2f87b

The listing’s review, conditional read-allow, and publisher-claim safeguards match the checked-in contracts; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding a publisher listing for mcp.mail-server.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Add publisher listing and claimant mapping for mcp.mail-server

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Add a v2 publisher listing for the existing mcp.mail-server contribution, documenting its coverage
 limits.
• Propose yunfeizhu’s numeric GitHub ID for publisher-profile management, subject to acceptance on
 canonical main.
• Record public contributor credit and upstream references separately from claim authority; runtime
 policy remains unchanged.
Diagram

graph TD
  A["MCP contribution"] --> B["Publisher listing"] --> C["Listing validation"] --> D{"Accepted on main?"} --> E["Claim eligibility"] --> F["Publisher profile"]
Loading
High-Level Assessment

Use the existing v2 listing mechanism: it separates public attribution from reviewed claim authority without changing the native contribution. Leaving the claimant mapping empty would preserve the current inability to claim a profile; adding it to runtime policy would cross the intended metadata boundary.

Files changed (1) +24 / -0

Enhancement (1) +24 / -0
mcp.mail-server.jsonAdd v2 publisher metadata and proposed claimant ID +24/-0

Add v2 publisher metadata and proposed claimant ID

• Adds presentation text describing the existing deletion-review coverage and launch-identity limits, plus public contributor, provenance, and upstream references. Proposes numeric GitHub ID 12027613 in maintainerGithubIds for publisher-profile management, subject to maintainer acceptance on canonical main.

contributions/extension-listings/mcp.mail-server.json

@gitar-bot

gitar-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🔴 High risk · Adding maintainerGithubIds for mcp.mail-server could authorize publisher-profile claims, allowing an incorrect mapping to grant profile control.

Adds a publisher listing file for the existing mcp.mail-server contribution (contributions/extension-listings/mcp.mail-server.json), proposing yunfeizhu (GitHub ID 12027613) as the authorized publisher-profile manager via maintainerGithubIds, pending maintainer acceptance on main. No issues found.

Review coverage

📋 Rules 2 not applicable

🧪 Functional validation Not enabled · Set up

Options ✅ Auto-apply

✅ Auto-apply is on → Gitar will commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

✅ Auto-apply Compact
gitar auto-apply:off         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@gitar-bot

gitar-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

Gitar is not allowed to push to this forked PR. Please enable "Allow edits from maintainers" to allow Gitar to push.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Gitar found a repair, but GitHub did not allow it to push to this fork.

If you want Gitar to apply safe mechanical follow-up fixes:

  1. Enable Allow edits from maintainers on this pull request.
  2. If GitHub instead says Allow edits and access to secrets by maintainers, leave it disabled and apply Gitar's suggestion yourself.
  3. Then comment gitar auto-apply:on to request another Gitar pass.

Only the fork owner can grant maintainer edits. This notice does not change access or request credentials.

@yunfeizhu

Copy link
Copy Markdown
Contributor Author

@kantorcodes @deep-purple-boots @zerocodefast could you please review this publisher-listing follow-up to #3278 and approve it if the proposed claimant mapping looks correct?

This PR only adds contributions/extension-listings/mcp.mail-server.json, proposing yunfeizhu (numeric GitHub ID 12027613) as the publisher-profile manager. The original contribution is already merged, but the profile cannot be claimed until this mapping is reviewed and accepted on main.

The PR has one commit, and all 109 focused listing/claim-notice tests passed locally. CI is still finishing. Please merge once the review and required checks pass so I can complete the Extension Studio claim. Thanks!

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@zerocodefast
zerocodefast merged commit 4736564 into hashgraph-online:main Oct 9, 2026
59 of 60 checks passed
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Your HOL Guard extension contribution is merged and its publisher page is ready to claim.

Claim your extension

Open your link and continue with GitHub using an account named above. Claiming creates a public publisher page that credits your GitHub account.

After claiming, Extension Studio lets you shape a launch story, prepare a setup guide and blog content, and use the verified publisher badge toolkit. Submit launch content for review when ready; claiming alone does not publish it.

Claim verification re-reads canonical main and checks the accepted numeric GitHub ID before granting publisher access. The publisher profile is separate from runtime trust, activation, or upstream ownership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitar-managed Enables Gitar automatic repair for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants