Skip to content

Commit dc79956

Browse files
harupyclaude
andcommitted
Disable archive: false until gh CLI supports non-zip artifacts
actions/upload-artifact v7 supports archive: false for raw uploads, but `gh run download` still hard-codes zip extraction (cli/cli#13012). Default back to archived uploads so `gh run download` works, and leave the archive: false line commented with a TODO so it's a one-line uncomment when the CLI catches up. Co-Authored-By: Claude <[email protected]> Signed-off-by: harupy <[email protected]>
1 parent f788814 commit dc79956

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎.github/workflows/js.yml‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,16 +82,18 @@ jobs:
8282
- name: Run tests
8383
env:
8484
MATRIX_OPTION: ${{ matrix.option }}
85-
PROFILE_DATA_FILE: /tmp/profile-metrics-${{ strategy.job-index }}.csv
8685
run: |
8786
"$GITHUB_WORKSPACE/dev/profile.sh" \
8887
yarn test --silent $MATRIX_OPTION src/experiment-tracking/components
8988
- name: Upload profile metrics
9089
if: always()
9190
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
9291
with:
93-
path: /tmp/profile-metrics-${{ strategy.job-index }}.csv
94-
archive: false
92+
name: profile-metrics-${{ strategy.job-index }}
93+
path: /tmp/profile-metrics.csv
94+
# TODO: Uncomment once `gh run download` supports non-zipped artifacts.
95+
# https://github.com/cli/cli/issues/13012
96+
# archive: false
9597
retention-days: 3
9698
if-no-files-found: ignore
9799
- name: Run build

0 commit comments

Comments
 (0)