Repository navigation
Commit 05bb83a
Skip KGP version validation for AGP built-in Kotlin (flutter#192206)
Fixes flutter#192167.
## Summary
When `android.builtInKotlin=true`, Kotlin is bundled with AGP and cannot
be upgraded independently. This change skips Flutter's KGP
minimum-version
validation for projects using AGP built-in Kotlin.
## Tests
- Added a regression test for an unsupported KGP version with
`android.builtInKotlin=true`.
- `./gradlew test --tests
'com.flutter.gradle.DependencyVersionCheckerTest'`
## Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined
there for submitting PRs.
- [x] I read the AI contribution guidelines and understand my
responsibilities.
- [x] I read the Tree Hygiene wiki page, which explains my
responsibilities.
- [x] I read and followed the Flutter Style Guide.
- [x] I signed the CLA.
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation, or verified that
none is needed for this internal validation change.
- [x] This PR does not introduce a new feature or capability; no
`flutter/website` documentation issue or PR is needed.
- [x] I added new tests to check the change I am making.
- [x] This is not a breaking change and does not require Data Driven
Fixes.
- [x] The relevant existing and new tests are passing.
---------
Co-authored-by: Aleksandr Pavlenko <[email protected]>
Co-authored-by: Aleksandr P. <[email protected]>1 parent b444e78 commit 05bb83a
2 files changed
Lines changed: 37 additions & 3 deletions
File tree
- packages/flutter_tools/gradle/src
- main/kotlin
- test/kotlin
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
144 | 146 | | |
145 | 147 | | |
146 | 148 | | |
147 | | - | |
148 | | - | |
| 149 | + | |
| 150 | + | |
149 | 151 | | |
150 | 152 | | |
151 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
171 | 173 | | |
172 | 174 | | |
173 | 175 | | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
174 | 200 | | |
175 | 201 | | |
176 | 202 | | |
| |||
422 | 448 | | |
423 | 449 | | |
424 | 450 | | |
| 451 | + | |
425 | 452 | | |
426 | 453 | | |
427 | 454 | | |
| |||
440 | 467 | | |
441 | 468 | | |
442 | 469 | | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
443 | 475 | | |
444 | 476 | | |
445 | 477 | | |
| |||
0 commit comments