Repository navigation
fix(webui): show 1.00 MB instead of 1024 KB just below a unit boundary - #1793
Merged
harry0703 merged 1 commit intoNov 12, 2026
Merged
Conversation
_format_file_size compared the unrounded value to 1024, then printed B and KB with .0f. A cache of 1048575 bytes therefore appeared as 1024 KB next to 1.00 MB at 1048576 bytes. Step up when rounding already reaches 1024 of the current unit.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
|
Thanks, @kevin9327! I checked the MB and GB boundaries in the settings page, and the display looks right now. Merged. Thanks for the fix and the regression tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_format_file_sizecompared the unrounded value to 1024, then printed B and KB with.0f. A cache of 1,048,575 bytes therefore appeared as1024 KBon the settings page, next to1.00 MBat exactly 1,048,576 bytes. The same happens at the GB boundary.The formatter now steps up when rounding already reaches 1024 of the current unit.
How Has This Been Tested?
test/services/test_webui_format_file_size.py, which loads_format_file_sizefromwebui/Main.pywithout rendering the Streamlit app.pytest test/services/test_webui_format_file_size.pypasses (2 tests).Checklist: