✨ feat(crawler): add flexible headless wait strategies for SPAs#1499
Merged
✨ feat(crawler): add flexible headless wait strategies for SPAs#1499
Conversation
Introduce `ChromiumWaitConfig` to replace the single fixed-delay approach with three composable strategies: - `network_idle`: waits for the CDP `networkIdle` lifecycle event - `wait_for_selector`: polls until a CSS selector appears in the DOM - `fixed_delay`: applies an unconditional delay after other strategies
…orkIdle listener before loading URL
… readability and structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
ChromiumWaitConfigto replace the single fixed-delay approach with three composable strategies:network_idle: waits for the CDPnetworkIdlelifecycle eventwait_for_selector: polls until a CSS selector appears in the DOMfixed_delay: applies an unconditional delay after other strategies