🐛 fix(mq-check): register ?? and .. as builtin operator overloads#1489
Merged
🐛 fix(mq-check): register ?? and .. as builtin operator overloads#1489
Conversation
The BinaryOp constraint generation looks up overloads via `symbol.value` (the raw token string). `??` resolves to `"??"` and `..` to `".."`, but builtins were only registered under `"coalesce"` and `"range"`, so `resolve_overload` always returned None, leaving both operators untyped. - Register `??` under both `"coalesce"` and `"??"` with two overloads: - `(None, a) -> a` for the null-coalescing case (`none ?? "default"`) - `(a, a) -> a` as same-type fallback - Register `..` under `".."` as binary-only `(number, number) -> [number]` plus `(None, None) -> None` for None propagation - Add integration tests for both operators
The `..` selector (Selector::Recursive) recursively collects all descendant markdown nodes and returns them as an array. The type checker was incorrectly returning Type::Markdown (same as `.h1` etc.) instead of Type::array(Type::Markdown). Fix both the piped-input path and the no-piped-input (top-level) path in constraint generation to return [markdown] for Selector::Recursive.
harehare
force-pushed
the
fix/typechecker-coalesce-range-operators
branch
from
5f52fbc to
204ff66
Compare
…rized tests Consolidate success and error cases into single rstest tables for test_coalesce_operator, test_range_operator, and test_recursive_selector, using a shared should_succeed: bool parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.