🐛 fix(markdown): filter empty values in Fragment render, join with newline#1431
Merged
🐛 fix(markdown): filter empty values in Fragment render, join with newline#1431
Conversation
Ensure Fragment node rendering skips empty values and joins non-empty with newline. Add tests for fragment rendering edge cases.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Markdown Fragment node rendering in mq-markdown to ignore empty rendered children and to separate non-empty children with newlines, improving output formatting for fragment-based selections and transformations.
Changes:
- Update
Node::Fragmentrendering to filter out empty rendered strings and join remaining parts with"\n". - Add unit tests covering fragment rendering edge cases (empty, single, multiple, filtering empties).
crates/mq-markdown/src/node.rs
Outdated
| .map(|value| value.render_with_theme(options, theme)) | ||
| .collect::<String>(), | ||
| .filter(|s| !s.is_empty()) | ||
| .collect::<Vec<_>>() |
There was a problem hiding this comment.
Fragment rendering allocates an intermediate Vec<String> just to call join("\n"). Since itertools::Itertools is already in scope and used elsewhere in this file, this can be simplified to join directly on the iterator (avoids an extra allocation and keeps the style consistent).
Suggested change
| .collect::<Vec<_>>() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure Fragment node rendering skips empty values and joins non-empty with newline. Add tests for fragment rendering edge cases.