🐛 fix: bracket-based selector syntax (.[n], .[n][m])#1430
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes bracket-based selector syntax so selectors like .[n] and .[n][m] are correctly recognized (including in HIR symbol extraction), and updates the published CLI help text to reflect the current set of CLI options.
Changes:
- Add parsing support for bracket-based selectors (
.[n],.[n][m],.[n][],.[][m]) inmq-langselector parsing and formatting. - Teach
mq-hirto construct the correctmq_lang::Selectorfrom CST nodes for bracket selectors (where the selector token is"."and brackets/indices are child tokens). - Remove outdated
--json/--csv/--yaml/...module flags from the duplicated CLI help text in docs and README.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/books/src/reference/cli.md | Removes outdated CLI flags from the documented help output. |
| crates/mq-lang/src/selector.rs | Adds bracket-selector parsing and updates selector string formatting/tests. |
| crates/mq-hir/src/hir.rs | Adds CST→Selector reconstruction for bracket selectors and updates HIR tests. |
| README.md | Keeps README CLI help text in sync by removing the same outdated flags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.