✨feat(lang): support def without params in parser#1413
Merged
Conversation
Owner
harehare
commented
Mar 10, 2026
harehare
commented
- Improve AST and CST parser to handle function definitions without parameters
- Add tests for def without params
- Update dependencies in Cargo.lock
- Improve AST and CST parser to handle function definitions without parameters - Add tests for def without params - Update dependencies in Cargo.lock
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in mq-lang parsers for def declarations that omit the parameter list entirely (e.g., def f: ...), aligning both CST and AST parsing and extending test coverage for the new syntax.
Changes:
- Update CST
parse_defto skip parameter parsing when a:follows the function name. - Update AST
parse_defto allow empty params when a:follows the function name. - Add parser tests for
defwithout params; refresh dependency lockfile.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/mq-lang/src/cst/parser.rs | Allow CST def parsing without (...) when directly followed by :; adds a CST test case. |
| crates/mq-lang/src/ast/parser.rs | Allow AST def parsing without (...) when directly followed by :; adds an AST test case. |
| Cargo.lock | Dependency lockfile updates. |
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.