Conversation
… parser and tests - TextEdit now uses character offsets (not bytes) - CharTextEdit reintroduced for explicit character edits - IncrementalParser updated for Ropey, multi-byte safety, and full-parse fallback - All affected tests updated for new API Closes #123 (if relevant)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates mq-lang’s CST incremental parsing utilities to treat TextEdit offsets as Unicode character (Rust char) offsets, improving multi-byte text correctness by storing source text as a ropey::Rope.
Changes:
- Switch
IncrementalParsersource storage fromStringtoRopeand add byte/char offset conversion helpers. - Change
TextEditsemantics to character offsets and updateapply_edit+ tests accordingly, including multi-byte coverage. - Add a full-parse fallback when a large fraction of top-level nodes are affected, and add the
ropeydependency.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| crates/mq-lang/src/cst/incremental.rs | Implements Rope-backed source storage, character-offset edits, conversion helpers, full-parse fallback, and updates tests/docs. |
| crates/mq-lang/Cargo.toml | Adds ropey dependency to mq-lang. |
| Cargo.toml | Adds ropey to workspace dependencies. |
| Cargo.lock | Locks ropey (and transitive deps) into the workspace lockfile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.