perf(mq-check): replace Vec with FxHashMap for deferred_overloads#1393
Merged
harehare merged 2 commits intofix/mq-check-overloadfrom Mar 5, 2026
Merged
perf(mq-check): replace Vec with FxHashMap for deferred_overloads#1393harehare merged 2 commits intofix/mq-check-overloadfrom
harehare merged 2 commits intofix/mq-check-overloadfrom
Conversation
…rt/replace Co-authored-by: harehare <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback from review on deferred overload replacement fix
perf(mq-check): replace Vec with FxHashMap for deferred_overloads
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_deferred_overloadwas doing a linear scan on every insert to find and replace an existing entry for the sameSymbolId, making the collection phase O(n²) for programs with many deferred overloads.Changes
InferenceContext::deferred_overloads:Vec<DeferredOverload>→FxHashMap<SymbolId, DeferredOverload>add_deferred_overload: replacediter_mut().find(...)+ conditional push with a singlemap.insert(symbol_id, deferred)— O(1) for both new entries and replacementstake_deferred_overloads: drains the map into aVec<DeferredOverload>, preserving the return type so all callers inlib.rsare unaffected🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.