🐛 fix(mq-check): correct deferred overload replacement and add regression test#1391
Merged
🐛 fix(mq-check): correct deferred overload replacement and add regression test#1391
Conversation
…on test - Fixes bug where stale deferred overloads could cause false type errors in Pass 4 - Adds regression test for gsub with default param in piped call
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a mq-check type inference edge case where deferred overload entries could become stale when the same symbol is re-processed after piped-input handling, and adds a regression test to prevent recurrence.
Changes:
- Replace existing deferred overload entries by
symbol_idinstead of always appending. - Add a regression test covering a piped
gsubcall using a defaulted function parameter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/mq-check/src/infer.rs | Updates deferred overload collection to replace stale entries for the same symbol. |
| crates/mq-check/src/builtin.rs | Adds a regression test for piped gsub with a default-parameter argument. |
Co-authored-by: Copilot <[email protected]>
Contributor
…rt/replace Co-authored-by: harehare <[email protected]>
perf(mq-check): replace Vec with FxHashMap for deferred_overloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.