Integrate mq-check crate and type checker options by harehare · Pull Request #1373 · harehare/mq

harehare · 2026-03-02T14:18:32Z

Add mq-check to workspace and dependencies
Implement type checker options in mq-check and mq-lsp
Pass type checker config from CLI to LSP server
Enable type error diagnostics in LSP when type checking is enabled
Add and update tests for type checker options in LSP

- Add mq-check to workspace and dependencies - Implement type checker options in mq-check and mq-lsp - Pass type checker config from CLI to LSP server - Enable type error diagnostics in LSP when type checking is enabled - Add and update tests for type checker options in LSP Closes #XXX (replace with actual issue if applicable)

Copilot

Pull request overview

This PR integrates the mq-check type-checking crate into the mq-lsp language server, exposing new CLI options to enable type checking and configure its behavior (strict arrays, tuple mode). When type checking is enabled and there are no parse errors, the LSP server runs the type checker and emits LSP diagnostics for detected type errors. The TypeCheckerOptions struct is also updated to derive Copy to eliminate unnecessary .clone() calls.

Changes:

mq-check is added to the workspace and as a dependency of mq-lsp
TypeCheckerOptions derives Copy; .clone() calls in mq-check/src/main.rs are replaced with direct copy
New CLI flags (-T, --strict-array, --tuple) are added to mq-lsp/src/main.rs; LspConfig::new gains two new parameters and type checking logic is added to the diagnostics method in server.rs

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`Cargo.toml`	Adds `mq-check` as a workspace dependency
`Cargo.lock`	Adds `mq-check` to `mq-lsp` resolved dependencies
`crates/mq-check/src/lib.rs`	Adds `Copy` to `TypeCheckerOptions` derive
`crates/mq-check/src/main.rs`	Replaces `.clone()` with copy for `TypeCheckerOptions`
`crates/mq-lsp/Cargo.toml`	Adds `mq-check` as a dependency
`crates/mq-lsp/src/main.rs`	Adds `TypeCheckArgs` CLI struct and wires to `LspConfig`
`crates/mq-lsp/src/server.rs`	Adds `config` field to `Backend`, implements type-error diagnostics, adds tests

crates/mq-lsp/src/main.rs

Cargo.toml

crates/mq-lsp/Cargo.toml

crates/mq-lsp/src/server.rs

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

editors/vscode/src/extension.ts

editors/vscode/package.json

crates/mq-lsp/src/main.rs

…in the server

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.

crates/mq-lsp/src/server.rs

crates/mq-lsp/src/error.rs

editors/vscode/package.json

…response with type information

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.

crates/mq-check/src/lib.rs

crates/mq-lsp/src/server.rs

crates/mq-lsp/src/inlay_hints.rs

crates/mq-lsp/src/server.rs

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

crates/mq-lsp/src/server.rs

harehare · 2026-03-04T00:41:14Z

@copilot
The build is failing with your latest changes. Could you fix it?

Copilot · 2026-03-04T00:41:21Z

@harehare I've opened a new pull request, #1383, to work on those changes. Once the pull request is ready, I'll request review from you.

…error Co-authored-by: harehare <[email protected]>

fix(mq-lsp): remove useless `.into()` conversion causing clippy failure

… and Zed - Neovim: add enable_type_check, strict_array, tuple, and enable_inlay_hints config options - Neovim: pass type-checking flags to mq-lsp and enable inlay hints on buffer attach - Zed: read enableTypeCheck/strictArray/tuple from initialization_options to build LSP args - Zed: support custom binary path via LspSettings - Zed: add serde_json dependency for parsing initialization options - Docs: update both editor READMEs with type checking and inlay hints usage examples

… reference symbols

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 2 comments.

crates/mq-lsp/src/server.rs

… types

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 25 out of 26 changed files in this pull request and generated 3 comments.

crates/mq-lsp/src/server.rs

crates/mq-check/src/lib.rs

crates/mq-lsp/src/error.rs

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 25 out of 26 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

crates/mq-lsp/src/lib.rs:15

The crates/mq-lsp/README.md does not document the new inlay hints capability or the new CLI flags (--enable-type-checking, --strict-array, --tuple). The codebase guidelines require documentation to be updated for new features in the crate README.

//! - **Hover**: Provides hover information for symbols, including type information when type checking is enabled.
//! - **Inlay Hints**: Shows inferred type annotations inline in the editor when type checking is enabled.
//! - **Completion**: Offers code completion suggestions.
//! - **Go To Definition**: Allows navigation to the definition of symbols.
//! - **References**: Finds all references to a symbol.
//! - **Document Symbols**: Lists all symbols in a document.
//! - **Semantic Tokens**: Provides semantic tokens for syntax highlighting.
//! - **Formatting**: Formats the document according to the MDQ language formatting rules.
//!

crates/mq-lsp/src/server.rs

crates/mq-check/src/builtin.rs

crates/mq-lsp/src/error.rs

crates/mq-lsp/src/server.rs

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.

crates/mq-lsp/src/main.rs

Copilot AI review requested due to automatic review settings March 2, 2026 14:18

Copilot started reviewing on behalf of harehare March 2, 2026 14:19 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

harehare and others added 2 commits March 2, 2026 23:41

✨ feat(vscode): Add configuration options for type checking

fec4dad

Update crates/mq-lsp/Cargo.toml

9d516b4

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings March 2, 2026 14:42

Copilot started reviewing on behalf of harehare March 2, 2026 14:43 View session

Update crates/mq-lsp/src/main.rs

31797f3

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Mar 2, 2026

View reviewed changes

editors/vscode/src/extension.ts Show resolved Hide resolved

editors/vscode/package.json Outdated Show resolved Hide resolved

crates/mq-lsp/src/main.rs Outdated Show resolved Hide resolved

harehare added 2 commits March 3, 2026 22:57

✨ feat(mq-lsp): implement LspError enum and integrate error handling …

8d8e94a

…in the server

🐛 fix: update debug binary path and improve error handling in LSP server

304acfd

Copilot AI review requested due to automatic review settings March 3, 2026 14:08

Copilot started reviewing on behalf of harehare March 3, 2026 14:08 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

harehare added 2 commits March 4, 2026 00:01

✨ feat(mq-lsp): add inlay hints for inferred types and enhance hover …

3d6d259

…response with type information

🔥 chore: remove unused import of TypeEnv in tests module

246c1e1

Copilot AI review requested due to automatic review settings March 3, 2026 15:14

Copilot started reviewing on behalf of harehare March 3, 2026 15:14 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Update crates/mq-check/src/lib.rs

f942d32

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings March 3, 2026 23:22

Copilot started reviewing on behalf of harehare March 3, 2026 23:23 View session

Update crates/mq-lsp/src/server.rs

120c13a

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Mar 3, 2026

View reviewed changes

crates/mq-lsp/src/server.rs Show resolved Hide resolved

Initial plan

af8083a

Copilot AI mentioned this pull request Mar 4, 2026

fix(mq-lsp): remove useless .into() conversion causing clippy failure #1383

Merged

fix(mq-lsp): remove useless .into() conversion in test to fix clippy …

7d8b43d

…error Co-authored-by: harehare <[email protected]>

harehare added 3 commits March 4, 2026 09:45

Merge pull request #1383 from harehare/copilot/sub-pr-1373

2fbb977

fix(mq-lsp): remove useless `.into()` conversion causing clippy failure

✨ fix(inlay_hints): extend inlay hint support for variable, call, and…

8126600

… reference symbols

Copilot AI review requested due to automatic review settings March 4, 2026 12:16

Copilot started reviewing on behalf of harehare March 4, 2026 12:17 View session

🐛 fix(server): remove type environment mapping on file close

f0f8f84

Copilot AI reviewed Mar 4, 2026

View reviewed changes

crates/mq-lsp/src/server.rs Show resolved Hide resolved

crates/mq-lsp/src/server.rs Show resolved Hide resolved

harehare and others added 2 commits March 4, 2026 21:43

✨ test: update arithmetic operator tests and error handling for mixed…

6a9dddf

… types

Update editors/vscode/package.json

987eb36

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings March 4, 2026 12:44

Copilot started reviewing on behalf of harehare March 4, 2026 12:44 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

crates/mq-lsp/src/server.rs Show resolved Hide resolved

crates/mq-check/src/lib.rs Show resolved Hide resolved

crates/mq-lsp/src/error.rs Outdated Show resolved Hide resolved

Update crates/mq-lsp/src/error.rs

aab3e76

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings March 4, 2026 13:06

Copilot started reviewing on behalf of harehare March 4, 2026 13:07 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Update crates/mq-lsp/src/inlay_hints.rs

7104c2b

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings March 4, 2026 13:19

Copilot started reviewing on behalf of harehare March 4, 2026 13:20 View session

harehare and others added 2 commits March 4, 2026 22:21

Update crates/mq-check/src/builtin.rs

65c8ffe

Co-authored-by: Copilot <[email protected]>

Update crates/mq-lsp/src/error.rs

7227114

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Mar 4, 2026

View reviewed changes

crates/mq-lsp/src/main.rs Show resolved Hide resolved

harehare merged commit 686818d into main Mar 4, 2026
6 checks passed

harehare deleted the chore/mq-check-integration branch March 4, 2026 13:37

BrewTestBot mentioned this pull request Mar 11, 2026

mq 0.5.18 Homebrew/homebrew-core#271763

Merged

Conversation

harehare commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

harehare commented Mar 4, 2026

Uh oh!

Copilot AI commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

harehare commented Mar 2, 2026 •

edited

Loading