test(mq-check): add negative cases for self pipe type propagation#1371
Closed
Copilot wants to merge 2 commits intofeat/mq-check-piped-self-constraintfrom
Closed
test(mq-check): add negative cases for self pipe type propagation#1371Copilot wants to merge 2 commits intofeat/mq-check-piped-self-constraintfrom
self pipe type propagation#1371Copilot wants to merge 2 commits intofeat/mq-check-piped-self-constraintfrom
Conversation
…ropagation Co-authored-by: harehare <[email protected]>
Copilot
AI
changed the title
[WIP] Update support for piped calls and self keyword
test(mq-check): add negative cases for Mar 2, 2026
self pipe type propagation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing tests for
selfkeyword and argument-position builtin calls only asserted absence of errors on valid input, leaving room for the positive cases to pass silently even if type propagation was broken.Changes
test_self_keyword_preserves_piped_type: three new!is_empty()checks confirm the type checker correctly rejects incompatible pipeline chains:These cases would silently pass if
selfdiscarded the piped type or if overload resolution was simply deferred without actual unification.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.