Fix undefined field access tests to assert TypeError::UndefinedField specifically#1366
Merged
harehare merged 2 commits intofix/typechecker-undefined-field-errorfrom Mar 1, 2026
Merged
Conversation
… access tests Co-authored-by: harehare <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on undefined field access error reporting
Fix undefined field access tests to assert TypeError::UndefinedField specifically
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The undefined field access tests only asserted
!result.is_empty(), which would pass for any type error—not justUndefinedField. Tests now assert the specific error variant and field name.Changes
test_selector_undefined_field_on_closed_record— assertsTypeError::UndefinedField { field: "c", .. }test_bracket_access_undefined_field_on_closed_record— assertsTypeError::UndefinedField { field: "missing", .. }🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.