Conversation
harehare
force-pushed
the
chore/github-actions-cargo-publish
branch
from
a56d556 to
2bcc7b0
Compare
- Add .github/workflows/cargo-publish.yml for crates.io publishing Closes #1133
harehare
force-pushed
the
chore/github-actions-cargo-publish
branch
from
2bcc7b0 to
188b1df
Compare
There was a problem hiding this comment.
Pull request overview
Adds an automated GitHub Actions workflow intended to publish the Rust workspace crates to crates.io on version tag pushes, aligning with the repo’s release automation goals (issue #1133).
Changes:
- Added a new
cargo-publish.ymlworkflow triggered onv*tag pushes (and manual dispatch) to dry-run and publish. - Updated
.gitignoreto ignoremutants.out.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.gitignore |
Ignores mutants.out output files. |
.github/workflows/cargo-publish.yml |
New workflow intended to publish crates to crates.io on tag pushes. |
| - name: Verify packages can be published | ||
| run: cargo publish --dry-run --workspace |
There was a problem hiding this comment.
Line contains a stray non-YAML character (│) and large trailing whitespace after the step name. This will make the workflow file invalid YAML and prevent GitHub Actions from loading it. Remove the extra character/whitespace so the name: value is plain text.
| run: cargo publish --dry-run --workspace | ||
| - name: Publish to crates.io | ||
| run: cargo publish --workspace |
There was a problem hiding this comment.
cargo publish is being run from the workspace root (which is a virtual manifest) and uses --workspace. In this repo the root Cargo.toml is [workspace]-only, and the workspace includes members with publish = false (e.g. crates/mq-ffi, crates/mq-wasm, crates/mq-python). As written, this step is likely to fail or attempt to publish crates that are intentionally non-publishable. Consider publishing explicit crates (via -p/--manifest-path) and excluding publish = false members, ideally in dependency order.
| run: cargo publish --dry-run --workspace | |
| - name: Publish to crates.io | |
| run: cargo publish --workspace | |
| run: cargo publish --dry-run --manifest-path crates/mq-run/Cargo.toml | |
| - name: Publish to crates.io | |
| run: cargo publish --manifest-path crates/mq-run/Cargo.toml |
Closes #1133