Avoid heap allocation in Convert::try_from symbol matching#1330
Merged
harehare merged 2 commits intofeat/convert-operator-supportfrom Feb 24, 2026
Merged
Avoid heap allocation in Convert::try_from symbol matching#1330harehare merged 2 commits intofeat/convert-operator-supportfrom
harehare merged 2 commits intofeat/convert-operator-supportfrom
Conversation
…Convert::try_from Co-authored-by: harehare <[email protected]>
Copilot
AI
changed the title
[WIP] WIP address feedback from PR #1320 on conversion operators
Avoid heap allocation in Convert::try_from symbol matching
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert::try_fromwas callingsymbol.as_str().as_str()to match on anIdent, which allocates a newStringon every call even for the happy path.Change
Replace the allocating pattern with
resolve_with, which passes the interned&strdirectly to the closure without any heap allocation:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.