✨ feat: add conversion operators by harehare · Pull Request #1320 · harehare/mq

harehare · 2026-02-23T14:12:41Z

No description provided.

harehare · 2026-02-23T14:13:18Z

@copilot
Can you check out the changes and add some document for conversion operators?

Copilot · 2026-02-23T14:13:25Z

@harehare I've opened a new pull request, #1321, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: harehare <[email protected]>

Copilot

Pull request overview

Adds a new conversion operator (@) to the mq language by introducing an Annotate token / binary op that maps to a new convert builtin, and refactors existing conversion helpers into a dedicated eval::builtin::convert module.

Changes:

Add @ token support in the lexer and wire it through CST/AST parsing as a binary operator.
Introduce convert builtin (and related conversion utilities) including Markdown/HTML/text/URI/base64 conversions.
Add url as a dependency to support URL-based conversions.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
crates/mq-lang/src/lexer/token.rs	Adds `TokenKind::Annotate` and display rendering for `@`.
crates/mq-lang/src/lexer.rs	Adds lexer parser for `@` and includes it in `binary_op` parsing.
crates/mq-lang/src/eval/builtin/convert.rs	New conversion utilities module + `Convert` / `ConvertKind` logic and tests.
crates/mq-lang/src/eval/builtin.rs	Wires `@` to new `CONVERT` builtin and moves conversion helpers to `convert` module; adds builtin docs entry.
crates/mq-lang/src/cst/parser.rs	Maps `TokenKind::Annotate` to `BinaryOp::Annotate`.
crates/mq-lang/src/cst/node.rs	Adds `BinaryOp::Annotate` variant.
crates/mq-lang/src/ast/parser.rs	Adds `Annotate` to binary-op detection, precedence, and builtin function mapping (`convert`).
crates/mq-lang/src/ast/constants.rs	Adds `builtins::CONVERT` constant.
crates/mq-lang/Cargo.toml	Adds `url` workspace dependency.
Cargo.lock	Locks `url` dependency addition.

crates/mq-lang/src/eval/builtin/convert.rs

crates/mq-lang/src/lexer.rs

crates/mq-lang/src/cst/parser.rs

crates/mq-lang/src/eval/builtin.rs

crates/mq-lang/src/eval/builtin/convert.rs

📝 docs: add documentation for the `@` conversion operator

codspeed-hq · 2026-02-23T14:26:26Z

Merging this PR will not alter performance

✅ 29 untouched benchmarks

_{Comparing feat/convert-operator-support (98557b8) with main (146a887)¹}

No successful run was found on main (facbdbc) during the generation of this report, so 146a887 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

harehare · 2026-02-23T14:34:55Z

@copilot
Can you check out the changes and rename Annotate to Conver?

Copilot · 2026-02-23T14:35:05Z

@harehare I've opened a new pull request, #1322, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: harehare <[email protected]>

♻️ refactor: rename `Annotate` to `Convert` in token/operator types

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

crates/mq-lang/src/eval/builtin/convert.rs

Copilot · 2026-02-24T00:00:53Z

@harehare I've opened a new pull request, #1329, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: harehare <[email protected]>

Add CST and AST parser tests for the `@` (convert) operator

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 8 comments.

crates/mq-lang/src/eval/builtin.rs

crates/mq-lang/src/error/runtime.rs

packages/mq-playground/src/Playground.tsx

editors/vscode/syntaxes/mq.tmLanguage.json

assets/mq.sublime-syntax

editors/neovim/syntax/mq.vim

crates/mq-lang/src/lexer/token.rs

crates/mq-lang/src/eval/builtin.rs

… checks

Copilot

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

crates/mq-lang/src/cst/node.rs:155

The BinaryOp enum variants are not in alphabetical order. Convert is placed between And and Assign, but alphabetically Assign should come before Convert. While the TokenKind enum (token.rs:49-128) explicitly maintains alphabetical order with a comment stating "TokenKind variants are sorted alphabetically for maintainability", the BinaryOp enum should follow the same convention.

The correct alphabetical order should be: And, Assign, Coalesce, Convert, Division, etc.

pub enum BinaryOp {
    And,
    Convert,
    Assign,
    Coalesce,
    Division,
    DivisionEqual,
    DoubleDivisionEqual,
    PipeEqual,
    Equal,
    Gt,
    Gte,
    Lt,
    Lte,
    Minus,
    MinusEqual,
    Modulo,
    ModuloEqual,
    Multiplication,
    MultiplicationEqual,
    NotEqual,
    Or,
    Plus,
    PlusEqual,
    RangeOp,
    RegexMatch,
    LeftShift,
    RightShift,
}

docs/books/src/reference/operators.md

crates/mq-lang/src/error.rs

editors/vscode/syntaxes/mq.tmLanguage.json

docs/books/src/reference/operators.md

…documentation

Co-authored-by: Copilot <[email protected]>

…Convert::try_from Co-authored-by: harehare <[email protected]>

Avoid heap allocation in Convert::try_from symbol matching

Copilot

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.

crates/mq-lang/src/error/runtime.rs

crates/mq-lang/src/eval/builtin/convert.rs

docs/books/src/reference/operators.md

crates/mq-lang/src/eval/builtin/convert.rs

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.

crates/mq-lang/src/error/runtime.rs

This reverts commit dee3ea9, reversing changes made to ade78fd.

…nterner

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

crates/mq-lang/src/ident.rs

crates/mq-lang/src/ast/constants.rs

crates/mq-lang/src/eval/builtin/convert.rs

Copilot · 2026-02-25T12:42:34Z

@harehare I've opened a new pull request, #1334, to work on those changes. Once the pull request is ready, I'll request review from you.

…d convert() Co-authored-by: harehare <[email protected]>

Add integration tests for conversion operator (@) and convert()

✨ Feat: add conversion operators

5ee0da0

Copilot AI review requested due to automatic review settings February 23, 2026 14:12

Copilot started reviewing on behalf of harehare February 23, 2026 14:13 View session

Initial plan

133ea9a

Copilot AI mentioned this pull request Feb 23, 2026

📝 docs: add documentation for the @ conversion operator #1321

Merged

harehare changed the title ~~✨ Feat: add conversion operators~~ ✨ feat: add conversion operators Feb 23, 2026

📝 docs: add documentation for conversion operators (@)

65f04c5

Co-authored-by: harehare <[email protected]>

Copilot AI reviewed Feb 23, 2026

View reviewed changes

Merge pull request #1321 from harehare/copilot/sub-pr-1320

5f3cdb1

📝 docs: add documentation for the `@` conversion operator

Initial plan

683abd6

Copilot AI mentioned this pull request Feb 23, 2026

♻️ refactor: rename Annotate to Convert in token/operator types #1322

Merged

Copilot AI and others added 2 commits February 23, 2026 14:40

♻️ refactor: rename Annotate to Convert in token/operator types

a875898

Co-authored-by: harehare <[email protected]>

Merge pull request #1322 from harehare/copilot/sub-pr-1320

fd1e44a

♻️ refactor: rename `Annotate` to `Convert` in token/operator types

Copilot AI review requested due to automatic review settings February 23, 2026 23:22

Copilot started reviewing on behalf of harehare February 23, 2026 23:23 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

crates/mq-lang/src/eval/builtin/convert.rs Outdated Show resolved Hide resolved

Initial plan

30ef140

Copilot AI mentioned this pull request Feb 24, 2026

Add CST and AST parser tests for the @ (convert) operator #1329

Merged

Copilot AI and others added 3 commits February 24, 2026 00:42

✅ test(lang): add CST and AST parser tests for convert (@) operator

747f7b7

Co-authored-by: harehare <[email protected]>

Merge pull request #1329 from harehare/copilot/sub-pr-1320

83e3ee3

Add CST and AST parser tests for the `@` (convert) operator

✨ feat: add support for convert operator and improve error handling

2392ef2

Copilot AI review requested due to automatic review settings February 24, 2026 12:23

Copilot started reviewing on behalf of harehare February 24, 2026 12:23 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

✨ feat: simplify link conversion logic by combining URL and file path…

0188c11

… checks

Copilot AI reviewed Feb 24, 2026

View reviewed changes

docs/books/src/reference/operators.md Show resolved Hide resolved

crates/mq-lang/src/error.rs Outdated Show resolved Hide resolved

editors/vscode/syntaxes/mq.tmLanguage.json Outdated Show resolved Hide resolved

docs/books/src/reference/operators.md Show resolved Hide resolved

harehare and others added 2 commits February 24, 2026 22:57

✨ feat: add support for Markdown strong/bold conversion in operators …

e7f82fc

…documentation

Update editors/vscode/syntaxes/mq.tmLanguage.json

97833a5

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings February 24, 2026 14:01

Update crates/mq-lang/src/error.rs

ade78fd

Co-authored-by: Copilot <[email protected]>

Copilot started reviewing on behalf of harehare February 24, 2026 14:01 View session

Copilot AI and others added 2 commits February 24, 2026 14:02

♻️ refactor(convert): use resolve_with to avoid String allocation in …

bf7fcdf

…Convert::try_from Co-authored-by: harehare <[email protected]>

Merge pull request #1330 from harehare/copilot/sub-pr-1320

dee3ea9

Avoid heap allocation in Convert::try_from symbol matching

Copilot AI reviewed Feb 24, 2026

View reviewed changes

harehare and others added 2 commits February 24, 2026 23:12

🎨 Format code

0196458

Update docs/books/src/reference/operators.md

5eedd9e

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings February 24, 2026 14:22

Copilot started reviewing on behalf of harehare February 24, 2026 14:22 View session

Update crates/mq-lang/src/error/runtime.rs

559f1f2

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Feb 24, 2026

View reviewed changes

crates/mq-lang/src/error/runtime.rs Show resolved Hide resolved

harehare added 3 commits February 25, 2026 08:06

Revert "Merge pull request #1330 from harehare/copilot/sub-pr-1320"

15f6063

This reverts commit dee3ea9, reversing changes made to ade78fd.

✨ Feat: add support for horizontal rule in Markdown conversion

f2dd085

🔧 Fix: replace Mutex with RwLock for improved concurrency in string i…

e1bdc69

…nterner

Copilot AI review requested due to automatic review settings February 25, 2026 12:30

Copilot started reviewing on behalf of harehare February 25, 2026 12:30 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

crates/mq-lang/src/ident.rs Show resolved Hide resolved

crates/mq-lang/src/ast/constants.rs Show resolved Hide resolved

crates/mq-lang/src/eval/builtin/convert.rs Show resolved Hide resolved

Initial plan

4922b99

Copilot AI mentioned this pull request Feb 25, 2026

Add integration tests for conversion operator (@) and convert() #1334

Merged

Copilot AI and others added 2 commits February 25, 2026 12:45

✅ test(mq-lang): add integration tests for conversion operator (@) an…

e793195

…d convert() Co-authored-by: harehare <[email protected]>

Merge pull request #1334 from harehare/copilot/sub-pr-1320

98557b8

Add integration tests for conversion operator (@) and convert()

harehare merged commit 3eb8bef into main Feb 25, 2026
7 checks passed

harehare deleted the feat/convert-operator-support branch February 25, 2026 13:03

BrewTestBot mentioned this pull request Feb 28, 2026

mq 0.5.17 Homebrew/homebrew-core#269913

Merged

Conversation

harehare commented Feb 23, 2026

Uh oh!

harehare commented Feb 23, 2026

Uh oh!

Copilot AI commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

harehare commented Feb 23, 2026

Uh oh!

Copilot AI commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 25, 2026

Uh oh!

Uh oh!

Reviewers

codspeed-hq bot commented Feb 23, 2026 •

edited

Loading