♻️ refactor(lang): change Number::to_int() to return i64 instead of u64#1317
Merged
harehare merged 2 commits intofeat/shift-header-levelfrom Feb 21, 2026
Merged
♻️ refactor(lang): change Number::to_int() to return i64 instead of u64#1317harehare merged 2 commits intofeat/shift-header-levelfrom
Number::to_int() to return i64 instead of u64#1317harehare merged 2 commits intofeat/shift-header-levelfrom
Conversation
Co-authored-by: harehare <[email protected]>
Copilot
AI
changed the title
[WIP] Add left shift and right shift token kinds and operations
♻️ refactor(lang): change Feb 21, 2026
Number::to_int() to return i64 instead of u64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Number::to_int()returnedu64, which caused silent wrapping for negative values (e.g.-1.0 as u64produces a very large number) and was inconsistent with howNumberalready usesi64in itsDisplayimpl.Changes
number.rs:to_int()now returnsi64viaself.0 as i64builtin.rs: Heading depth callers updated to clamp safely with.max(0).min(u8::MAX as i64) as u8, preventing negative shift amounts from producing incorrectu8values💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.