✨ feat(mq-lang): add =~ regex match operator and is_regex_match builtin by harehare · Pull Request #1305 · harehare/mq

harehare · 2026-02-20T14:25:15Z

Add =~ as a binary operator for regex matching (maps to is_regex_match)
Implement is_regex_match builtin function
Update parser, CST, AST, lexer, and token definitions
Add tests and update syntax highlighting for all editors

- Add =~ as a binary operator for regex matching (maps to is_regex_match) - Implement is_regex_match builtin function - Update parser, CST, AST, lexer, and token definitions - Add tests and update syntax highlighting for all editors Closes #1274

Copilot

Pull request overview

This PR adds a regex match operator (=~) and the is_regex_match builtin function to the mq language, providing a more ergonomic way to perform regex matching compared to the previous test() function that required chaining regex_match() with !is_empty(). The operator maps to the is_regex_match builtin, which returns a boolean indicating whether a pattern matches a string.

Changes:

Added =~ binary operator for regex matching (note: issue #1274 specified ~= but implementation uses =~)
Implemented is_regex_match builtin function that returns boolean instead of an array of matches
Updated test() function in builtin.mq to use the more efficient is_regex_match directly
Updated syntax highlighting across all editors (VSCode, Neovim, Zed, Playground, REPL)

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
crates/mq-lang/src/lexer/token.rs	Added `TildeEqual` token kind for the `=~` operator
crates/mq-lang/src/lexer.rs	Added lexer parser for `=~` token and included it in binary operators
crates/mq-lang/src/cst/node.rs	Added `RegexMatch` variant to BinaryOp enum
crates/mq-lang/src/cst/parser.rs	Mapped `TildeEqual` token to `RegexMatch` binary operation
crates/mq-lang/src/ast/parser.rs	Set operator precedence, mapped to builtin function, added to operator recognition
crates/mq-lang/src/ast/constants.rs	Added `IS_REGEX_MATCH` constant for the builtin function name
crates/mq-lang/src/eval/builtin.rs	Implemented `IS_REGEX_MATCH` builtin with hash constant, dispatch entry, and helper function
crates/mq-lang/builtin.mq	Simplified `test()` to use `is_regex_match` directly instead of `regex_match` + `!is_empty()`
crates/mq-lang/tests/integration_tests.rs	Added basic test case for the `=~` operator
editors/vscode/syntaxes/mq.tmLanguage.json	Added `=~` to VSCode syntax highlighting
editors/neovim/syntax/mq.vim	Added `=~` to Neovim syntax highlighting
editors/zed/languages/mq/highlights.scm	Added `=~` to Zed syntax highlighting
packages/mq-playground/src/Playground.tsx	Added `=~` to Monaco editor syntax highlighting
crates/mq-repl/src/repl.rs	Added `=~` to REPL syntax highlighting

crates/mq-lang/tests/integration_tests.rs

crates/mq-lang/src/ast/parser.rs

editors/neovim/syntax/mq.vim

crates/mq-lang/src/eval/builtin.rs

crates/mq-lang/src/lexer/token.rs

crates/mq-lang/src/ast/parser.rs

packages/mq-playground/src/Playground.tsx

crates/mq-lang/src/eval/builtin.rs

codspeed-hq · 2026-02-20T14:49:04Z

Merging this PR will not alter performance

✅ 29 untouched benchmarks

_{Comparing feat/regex-match-operator (168dedb) with main (361faa2)¹}

No successful run was found on main (c441c97) during the generation of this report, so 361faa2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

crates/mq-lang/src/ast/parser.rs

editors/neovim/syntax/mq.vim

… arithmetic operators

harehare · 2026-02-21T03:24:22Z

@copilot
Can you check out the changes and add some tests them?

Copilot · 2026-02-21T03:24:30Z

@harehare I've opened a new pull request, #1310, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: harehare <[email protected]>

✅ test(mq-lang): expand =~ operator and is_regex_match test coverage

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Copilot · 2026-02-21T03:56:57Z

assets/mq.sublime-syntax

    - match: '\b(def|do|let|if|elif|else|end|while|foreach|self|nodes|match|fn|break|continue|include|import|module|var|macro|quote|unquote|loop)\b'
      scope: keyword.control.mq
-    - match: '(->|=|\||:|;|\?|!|\+|\-|\*|/|%|<|>|<=|>=|==|!=|&&)'
+    - match: '(->|=|\||:|;|\?|!|\+|\-|\*|/|%|<|>|<=|>=|==|!=|&&|=~)'


The =~ operator is placed after the = operator in the alternation pattern. In regex alternations, patterns are tried left-to-right, so the single = will match before =~ gets a chance to be tested. This will cause =~ to be incorrectly highlighted as two separate operators (= and ~).

The =~ operator should be placed before the single = operator in the pattern to ensure it matches correctly. The corrected pattern should be:
'(->|=~|=|\||:|;|\?|!|\+|\-|\*|/|%|<|>|<=|>=|==|!=|&&)'

This ensures that two-character operators like =~, <=, >=, ==, != are matched before their single-character prefixes.

Suggested change

- match: '(->|=|\||:|;|\?|!|\+|\-|\*|/|%|<|>|<=|>=|==|!=|&&|=~)'

- match: '(->|=~|=|\||:|;|\?|!|\+|\-|\*|/|%|<|>|<=|>=|==|!=|&&)'

Copilot · 2026-02-21T03:56:58Z

crates/mq-lang/src/eval/builtin.rs

+const HASH_IS_REGEX_MATCH: u64 = fnv1a_hash_64("is_regex_match");
 const HASH_IS_NAN: u64 = fnv1a_hash_64("is_nan");


The hash constant HASH_IS_REGEX_MATCH is not in alphabetical order. According to the codebase convention (see memory about hash constants being in alphabetical order), hash constants should be ordered alphabetically by function name.

Currently:

HASH_IS_DEBUG_MODE (is_debug_mode)

HASH_IS_REGEX_MATCH (is_regex_match)

HASH_IS_NAN (is_nan)

Alphabetically correct order should be:

HASH_IS_DEBUG_MODE (is_debug_mode)

HASH_IS_NAN (is_nan)

HASH_IS_REGEX_MATCH (is_regex_match)

The constant should be moved to line 2445 (after HASH_IS_NAN).

Suggested change

const HASH_IS_REGEX_MATCH: u64 = fnv1a_hash_64("is_regex_match");

const HASH_IS_NAN: u64 = fnv1a_hash_64("is_nan");

const HASH_IS_NAN: u64 = fnv1a_hash_64("is_nan");

const HASH_IS_REGEX_MATCH: u64 = fnv1a_hash_64("is_regex_match");

harehare · 2026-02-21T06:01:48Z

@copilot
Could you document the Regex operator?

Copilot · 2026-02-21T06:01:55Z

@harehare I've opened a new pull request, #1311, to work on those changes. Once the pull request is ready, I'll request review from you.

…sh constant ordering and sublime-syntax operator placement Co-authored-by: harehare <[email protected]>

Co-authored-by: harehare <[email protected]>

📝 docs(mq-lang): document =~ regex match operator; fix hash ordering and syntax highlighting

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

crates/mq-lang/src/lexer.rs

Copilot AI review requested due to automatic review settings February 20, 2026 14:25

Copilot started reviewing on behalf of harehare February 20, 2026 14:25 View session

✨ feat(mq-lang): add =~ operator to keywords for regex matching

455b981

Copilot AI reviewed Feb 20, 2026

View reviewed changes

✨ feat(tests): add regex match and non-match cases to integration tests

3039c9b

Update crates/mq-lang/src/eval/builtin.rs

a5de894

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings February 20, 2026 15:05

Copilot started reviewing on behalf of harehare February 20, 2026 15:05 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

crates/mq-lang/src/ast/parser.rs Show resolved Hide resolved

editors/neovim/syntax/mq.vim Show resolved Hide resolved

✨ feat(parser): improve operator precedence handling for equality and…

b876eaf

… arithmetic operators

Initial plan

ba62571

Copilot AI mentioned this pull request Feb 21, 2026

✅ test(mq-lang): expand =~ operator and is_regex_match test coverage #1310

Merged

Copilot AI and others added 3 commits February 21, 2026 03:36

✅ test(mq-lang): add comprehensive tests for =~ regex match operator

d5fba75

Co-authored-by: harehare <[email protected]>

✅ test(mq-lang): add direct tests for is_regex_match builtin function

ae78427

Co-authored-by: harehare <[email protected]>

Merge pull request #1310 from harehare/copilot/sub-pr-1305

afdbca9

✅ test(mq-lang): expand =~ operator and is_regex_match test coverage

Copilot AI review requested due to automatic review settings February 21, 2026 03:51

Copilot started reviewing on behalf of harehare February 21, 2026 03:52 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Update mq.sublime-syntax

dad84f4

Initial plan

5129a2e

Copilot AI mentioned this pull request Feb 21, 2026

📝 docs(mq-lang): document =~ regex match operator; fix hash ordering and syntax highlighting #1311

Merged

4 tasks

Copilot AI and others added 3 commits February 21, 2026 06:08

📝 docs: add =~ regex operator documentation to comparisons.md; fix ha…

1fe93c4

…sh constant ordering and sublime-syntax operator placement Co-authored-by: harehare <[email protected]>

📝 docs: fix if syntax in comparisons.md to use correct mq syntax

1ad1278

Co-authored-by: harehare <[email protected]>

Update mq.sublime-syntax

fb1c2d8

Merge pull request #1311 from harehare/copilot/sub-pr-1305

168dedb

📝 docs(mq-lang): document =~ regex match operator; fix hash ordering and syntax highlighting

Copilot AI review requested due to automatic review settings February 21, 2026 06:39

Copilot started reviewing on behalf of harehare February 21, 2026 06:40 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

crates/mq-lang/src/lexer.rs Show resolved Hide resolved

harehare merged commit 7f8f213 into main Feb 21, 2026
11 checks passed

harehare deleted the feat/regex-match-operator branch February 21, 2026 12:31

BrewTestBot mentioned this pull request Feb 28, 2026

mq 0.5.17 Homebrew/homebrew-core#269913

Merged

	- match: '(->\|=\|\\|\|:\|;\|\?\|!\|\+\|\-\|\*\|/\|%\|<\|>\|<=\|>=\|==\|!=\|&&\|=~)'
	- match: '(->\|=~\|=\|\\|\|:\|;\|\?\|!\|\+\|\-\|\*\|/\|%\|<\|>\|<=\|>=\|==\|!=\|&&)'

		const HASH_IS_REGEX_MATCH: u64 = fnv1a_hash_64("is_regex_match");
		const HASH_IS_NAN: u64 = fnv1a_hash_64("is_nan");

Conversation

harehare commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

harehare commented Feb 21, 2026

Uh oh!

Copilot AI commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

harehare commented Feb 21, 2026

Uh oh!

Copilot AI commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq bot commented Feb 20, 2026 •

edited

Loading